Closed
Bug 1250430
Opened 9 years ago
Closed 9 years ago
Remove support of "srcdir" loader
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(firefox47 fixed)
RESOLVED
FIXED
Firefox 47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
Now that we have the reload addon, there isn't much value in keeping the srcdir loader which offer a subset of what the addon already do.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8722446 -
Flags: review?(jryans)
Comment on attachment 8722446 [details] [diff] [review]
patch v1
Review of attachment 8722446 [details] [diff] [review]:
-----------------------------------------------------------------
::: devtools/client/webide/content/webide.js
@@ -1156,5 @@
> UI.contentViewer.fullZoom = 1;
> Services.prefs.setCharPref("devtools.webide.zoom", 1);
> },
>
> reloadDevtools: function(event) {
Do we need this empty function...? Does something else call it?
Attachment #8722446 -
Flags: review?(jryans) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3)
> Comment on attachment 8722446 [details] [diff] [review]
> patch v1
>
> Review of attachment 8722446 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: devtools/client/webide/content/webide.js
> @@ -1156,5 @@
> > UI.contentViewer.fullZoom = 1;
> > Services.prefs.setCharPref("devtools.webide.zoom", 1);
> > },
> >
> > reloadDevtools: function(event) {
>
> Do we need this empty function...? Does something else call it?
The xul:command from webide.xul, but I removed it. That's just a leftover.
|
|
Assignee | |
Comment 5•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8722446 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/49253a251d3e6b783e7d985a81b669e2eeb31c97
Bug 1250430 - Remove SrcDir loader support from devtools. r=jryans
|
||
Comment 8•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•