the geko patch for network error needs to enable tv build preference.

[Blocking Requested - why for this release]:

Comment on attachment 8722889 [details] [gaia] danhuang1202:1250815_enable_network_error_preference > mozilla-b2g:master Hi Luke, please help review this patch. This patch enable tv build preference to support geko update. Thanks.

Thanks for the review! Merge in master: https://github.com/mozilla-b2g/gaia/commit/fc443d40274a15be826c873b70a4d5f641762573

Comment on attachment 8722889 [details] [gaia] danhuang1202:1250815_enable_network_error_preference > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #):Bug 1187806 [User impact] if declined: The network error string not correct. [Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=fc443d40274a15be826c873b70a4d5f641762573 [Risk to taking this patch] (and alternatives if risky): None [String changes made]: None

Comment on attachment 8722889 [details] [gaia] danhuang1202:1250815_enable_network_error_preference > mozilla-b2g:master Approve for TV 2.5

this has conflicts 8766deb..51b8136 v2.5 -> v2.5 Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick fc443d40274a15be826c873b70a4d5f641762573 error: could not apply fc443d4... Bug 1250815 - enable tv build preference: network.offline-mirrors-connectivity hint: after resolving the conflicts, mark the corrected paths hint: with 'git add <paths>' or 'git rm <paths>' hint: and commit the result with 'git commit'

Hi Tomcat, conflict fixed! Merge in v2.5: https://github.com/mozilla-b2g/gaia/commit/65dc50d9b7f808a78d01d09d4242378eb9af283f

This issue is verified on v2.6. The network offline error preference is added in gaia/build/config/tv/custom-prefs.js and the default value is true. When setting network offline, the corresponding string "Need an internet connection". [Build Info] gaia: https://github.com/mozilla-b2g/gaia/commit/ae8fe4552de265860970162f1d199ec6326fc51d gecko: https://hg.mozilla.org/mozilla-central/rev/b6acf4d4fc20431a8ae14bf32cdc6e43a9c0f9ad However, although the network offline error preference is true in v2.5, the offline string shows "Server not found" when detecting offline status. [Build Info] gaia: https://github.com/mozilla-b2g/gaia/commit/65dc50d9b7f808a78d01d09d4242378eb9af283f mulet: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3

Hi Cindy, this string has a platform dependency issue bug1253488 and its related issue bug1250804, refer to your comment10, the preference is already enabled and I'll close this issue here