Closed Bug 1251492 Opened 9 years ago Closed 9 years ago

[DevTools][Memory] menuitem does not work while the Dominators is displayed

Categories

(DevTools :: Shared Components, defect, P1)

47 Branch
defect

Tracking

(firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: magicp.jp, Assigned: fitzgen)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0 Build ID: 20160225030209 Steps to reproduce: 1. Start Nightly (2016-02-25) 2. Open DevTools > Memory 3. Switch to Dominators view 4. Run Take snapshot 5. Select any menuitem in menubar and context menus Actual results: menuitem does not work while the Dominators is displayed. Expected results: menuitem works even while the Dominators is displayed.
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → Developer Tools: Memory
Flags: needinfo?(nfitzgerald)
OS: Unspecified → All
Hardware: Unspecified → All
Thanks for the report and regression range, magicp. I don't understand what you mean by: > 5. Select any menuitem in menubar and context menus Which menuitem, menubar, and context menus? The dominator tree view doesn't have any of those. I tried reproducing with context menus on the page and was unable to reproduce.
Flags: needinfo?(nfitzgerald) → needinfo?(magicp.jp)
Attached video 20160227075547.mp4 (deleted) —
(In reply to Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8] from comment #2) > Which menuitem, menubar, and context menus? The dominator tree view doesn't > have any of those. I tried reproducing with context menus on the page and > was unable to reproduce. All of menuitems are no response.
Flags: needinfo?(magicp.jp)
Ah, thanks I understand now!
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Priority: -- → P1
Component: Developer Tools: Memory → Developer Tools: Shared Components
Comment on attachment 8724277 [details] [diff] [review] Don't prevent default behavior of unrelated mouse events in HSplitBox Review of attachment 8724277 [details] [diff] [review]: ----------------------------------------------------------------- It looks like this is failing a relevant test > 211 INFO TEST-UNEXPECTED-FAIL | devtools/client/shared/components/test/mochitest/test_HSplitBox_01.html | Should get 1 resize - got +0, expected 1
Attachment #8724277 - Flags: review?(lclark) → review-
Turns out we were simulating the wrong mouse button in the test, hence the try failures >.<
Attachment #8725793 - Flags: review?(lclark)
Attachment #8724277 - Attachment is obsolete: true
Comment on attachment 8725793 [details] [diff] [review] Don't prevent default behavior of unrelated mouse events in HSplitBox Review of attachment 8725793 [details] [diff] [review]: ----------------------------------------------------------------- In case anyone else needs the STR, there was a small clarification that I needed: In Step #5, the first right click (to bring up the contextual menu) works. Where you see the bug is when you try to click on anything inside of that contextual menu. The OP showed this in the video. This patch does what it says on the tin, so r+.
Attachment #8725793 - Flags: review?(lclark) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
I have successfully reproduce this bug on firefox nightly 47.0a1 (2016-02-25) with windows 7 (32 bit) Mozilla/5.0 (Windows NT 6.1; rv:47.0) Gecko/20100101 Firefox/47.0 I found this fix on latest aurora 47.0a2 (2016-04-20) Mozilla/5.0 (Windows NT 6.1; rv:47.0) Gecko/20100101 Firefox/47.0 Build ID : 20160420004046 [bugday-20160420]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: