Closed Bug 1251541 Opened 9 years ago Closed 9 years ago

gecko/ipc/hal/DaemonSocketPDUHelpers.h:789:29: error: expected ')' before '<' token

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

Product:
Firefox OS Graveyard
Component:
GonkIntegration
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox47 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: gwagner, Assigned: tzimmermann)

References

Details

Attachments

(3 files)

[01] Bug 1251541: Replace |nsAutoArrayPtr<>| with |UniquePtr<[]>| in Bluetooth managers
(deleted), patch
shawnjohnjr
: review+
Details | Diff | Splinter Review
[02] Bug 1251541: Pass arguments to AVRCP passthrough command as uint8_t
(deleted), patch
shawnjohnjr
: review+
Details | Diff | Splinter Review
[03] Bug 1251541: Replace |nsAutoArrayPtr<>| with |UniquePtr<[]>| in Bluetooth interfaces
(deleted), patch
shawnjohnjr
: review+
Details | Diff | Splinter Review
No description provided.
Blocks: 1229985, 1245091
Thomas, can you remove nsAutoArrayPtr from DaemonSocketPDUHelpers?
Yep
Assignee: nobody → tzimmermann
Status: NEW → ASSIGNED
Hi This patch completely replaces |nsAutoArrayPtr<>| with |UniquePtr<[]>| in the Bluetooth module. Asking for a fast review here, as the build will break as soon as bug 1229985 reaches m-c.
Comment on attachment 8724061 [details] [diff] [review] [02] Bug 1251541: Pass arguments to AVRCP passthrough command as uint8_t LGTM
Attachment #8724061 - Flags: review?(shuang) → review+
Comment on attachment 8724063 [details] [diff] [review] [03] Bug 1251541: Replace |nsAutoArrayPtr<>| with |UniquePtr<[]>| in Bluetooth interfaces Review of attachment 8724063 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me
Attachment #8724063 - Flags: review?(shuang) → review+
Comment on attachment 8724060 [details] [diff] [review] [01] Bug 1251541: Replace |nsAutoArrayPtr<>| with |UniquePtr<[]>| in Bluetooth managers Review of attachment 8724060 [details] [diff] [review]: ----------------------------------------------------------------- Forward it to me.
Attachment #8724060 - Flags: review?(btian) → review?(shuang)
Comment on attachment 8724060 [details] [diff] [review] [01] Bug 1251541: Replace |nsAutoArrayPtr<>| with |UniquePtr<[]>| in Bluetooth managers Review of attachment 8724060 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, if this fix build break.
Attachment #8724060 - Flags: review?(shuang) → review+
Shawn, thank you so much for reviewing this patch set quickly.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: