Closed
Bug 1251663
Opened 9 years ago
Closed 8 years ago
Support query cancelation for Presto in redash/PyHive
Categories
(Cloud Services Graveyard :: Metrics: Pipeline, defect, P1)
Cloud Services Graveyard
Metrics: Pipeline
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rvitillo, Assigned: frank)
References
Details
Redash has a button to cancel a query but it doesn't forward the command to Presto as PyHive doesn't support it.
Updated•9 years ago
|
Points: --- → 3
Priority: -- → P3
Comment 1•8 years ago
|
||
This is tracked on https://github.com/dropbox/PyHive/issues/2
Updated•8 years ago
|
Priority: P3 → P2
Assignee | ||
Comment 2•8 years ago
|
||
This fix looked pretty straightforward so I submitted a PR to PyHive: https://github.com/dropbox/PyHive/pull/80
Reporter | ||
Comment 3•8 years ago
|
||
As mentioned in IRC we are currently using a fork of PyHive so it would be great if you could submit a PR against our fork. Extra points for submitting a PR with our changes upstream.
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → fbertsch
Priority: P2 → P1
Assignee | ||
Comment 4•8 years ago
|
||
Submitted a PR with my changes against our downstream version. What should perhaps happen is the following:
1. Approve PR #3 [0] to bring our downstream version up-to-date
2. Rebase PR #2 (query cancellation) [1] and branch "pretty" on top of changes
3. Complete code review and merge PR #2
4. Merge branches "pretty" and "presto_cancel" and deploy that for our own use
5. Submit two PRs to upstream code with our changes
[0] https://github.com/vitillo/PyHive/pull/3
[1] https://github.com/vitillo/PyHive/pull/2
Assignee | ||
Comment 5•8 years ago
|
||
We have a branch [0] that has both query cancellation and pretty printing, which we will use for our own deployment. I have submitted two PRs to PyHive, with both of those changes. Next step is update our version of re:dash to support cancellation.
[0] https://github.com/vitillo/PyHive/tree/deployment
Assignee | ||
Comment 6•8 years ago
|
||
Deployment [0] commit log has been cleaned.
[0] https://github.com/vitillo/PyHive/tree/deployment
Assignee | ||
Comment 7•8 years ago
|
||
Changes deployed and working!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Cloud Services → Cloud Services Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•