Closed
Bug 1251737
Opened 9 years ago
Closed 9 years ago
Remove remaining references to MOZILLA_XPCOMRT_API from media
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
Now that MOZILLA_XPCOMRT_API has been retired we can remove references to it in media.
Several files reference the define:
> media/mtransport/nricectx.cpp:1
> media/mtransport/standalone/moz.build:1
> media/mtransport/nr_socket_prsock.h:3
> media/mtransport/nr_socket_prsock.cpp:7
> media/mtransport/stun_udp_socket_filter.cpp:2
> media/webrtc/signaling/signaling.gyp:1
> media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.cpp:6
> media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:4
> media/webrtc/signaling/src/peerconnection/PeerConnectionMedia.h:3
> media/webrtc/signaling/src/peerconnection/MediaPipelineFactory.cpp:2
> media/webrtc/signaling/src/common/browser_logging/WebRtcLog.cpp:4
> media/webrtc/signaling/src/media-conduit/CodecStatistics.cpp:9
> media/webrtc/signaling/src/media-conduit/VideoConduit.cpp:1
> media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp:4
> media/webrtc/signaling/src/mediapipeline/MediaPipeline.h:1
> media/webrtc/signaling/test/signaling_unittests.cpp:4
> media/webrtc/signaling/test/FakeLogging.h:1
|
Assignee | |
Comment 1•9 years ago
|
||
:jesup, please feel free to redirect if you think someone else should review this.
Attachment #8724278 -
Flags: review?(rjesup)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•9 years ago
|
||
It looks like we can remove mtransport_standalone completely, it is no longer referenced.
Attachment #8724304 -
Flags: review?(rjesup)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8724278 -
Attachment is obsolete: true
Attachment #8724278 -
Flags: review?(rjesup)
|
||
Updated•9 years ago
|
Attachment #8724304 -
Flags: review?(rjesup) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ad133741957d08c0afdcbe6eeeabc9fb5a2b9cf
Bug 1251737 - Remove remaining references to MOZILLA_XPCOMRT_API from media. r=jesup
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•