Closed
Bug 1251856
Opened 9 years ago
Closed 9 years ago
U2F-related test_interfaces.html is going to permafail when Gecko 47 merges to Beta
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox45 | --- | unaffected |
firefox46 | --- | unaffected |
firefox47 | - | fixed |
People
(Reporter: RyanVM, Assigned: jcj)
References
Details
Attachments
(1 file)
[Tracking Requested - why for this release]: Merge day permafail.
Looks like test_interfaces.html needs to be updated.
https://treeherder.mozilla.org/logviewer.html#?job_id=17314340&repo=try
TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface U2F to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
Flags: needinfo?(jjones)
Assignee | ||
Comment 1•9 years ago
|
||
Ryan: I guess this is what Baku was referring to in the last line of https://bugzilla.mozilla.org/show_bug.cgi?id=1231681#c14 about build-specific #ifdefs, though I'm still unclear as to the correct resolution.
The semantics we want is for window.u2f to be opt-in via pref on all builds, for the foreseeable future. What do I need to do to make that true?
Flags: needinfo?(jjones)
Assignee | ||
Comment 2•9 years ago
|
||
* Pref off the "U2F" interface to blank out the integer constants, and
* Disable U2F in all releases.
Review commit: https://reviewboard.mozilla.org/r/37157/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37157/
Attachment #8724786 -
Flags: review?(amarchesini)
Assignee | ||
Comment 3•9 years ago
|
||
Assignee: nobody → jjones
Status: NEW → ASSIGNED
Comment 4•9 years ago
|
||
Comment on attachment 8724786 [details]
MozReview Request: Bug 1251856 - Disable U2F in all releases (fix for 1231681) r?baku
https://reviewboard.mozilla.org/r/37157/#review33943
::: dom/webidl/U2F.webidl:71
(Diff revision 1)
> +[Pref="security.webauth.u2f"]
is this pref set to false somewhere?
Attachment #8724786 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Thanks for the review, baku!
Assignee | ||
Comment 6•9 years ago
|
||
https://reviewboard.mozilla.org/r/37157/#review33943
> is this pref set to false somewhere?
Yes, in `netwerk/base/security-prefs.js` it's set false. :)
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•9 years ago
|
Target Milestone: --- → mozilla47
Comment 9•9 years ago
|
||
bugherder |
Don't feel the need to track this since it's fixed.
You need to log in
before you can comment on or make changes to this bug.
Description
•