Closed Bug 1251875 Opened 9 years ago Closed 9 years ago

Remove the dom.serviceWorkers.interception.enabled pref

Categories

(Core :: DOM: Service Workers, defect)

Product:
Core
Component:
DOM: Service Workers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

(Whiteboard: btpp-active)

Attachments

(2 files)

Patch (v1)
(deleted), patch
bkelly
: review+
Details | Diff | Splinter Review
Part 2: Remove the dom.serviceWorkers.interception.opaque.enabled pref
(deleted), patch
bkelly
: review+
Details | Diff | Splinter Review
I'd like to do this now, since we won't go back to the state where we want to ship the API but unship the actual interception. Any objections, Ben?
Flags: needinfo?(bkelly)
We need the pref for 45esr, but OK removing it in 47+.
Flags: needinfo?(bkelly)
Whiteboard: btpp-active
Attached patch Patch (v1) (deleted) — — Splinter Review
Attachment #8724894 - Flags: review?(bkelly)
Comment on attachment 8724894 [details] [diff] [review] Patch (v1) Review of attachment 8724894 [details] [diff] [review]: ----------------------------------------------------------------- r=me if it passes a try build. Want to do a P2 patch to remove the opaque interception pref?
Attachment #8724894 - Flags: review?(bkelly) → review+
This bug 1251875, Remove the dom.serviceWorkers.interception.enabled pref, has been reviewed. An engineer is working on this bug. You will receive emailed updates on the progress of your bug’s fix from Bugzilla, so make sure that bugzilla-daemon@mozilla.org is not blocked in your spam filters. Thank you.
> Want to do a P2 patch to remove the opaque interception pref? Yep, will do!
Comment on attachment 8725041 [details] [diff] [review] Part 2: Remove the dom.serviceWorkers.interception.opaque.enabled pref Review of attachment 8725041 [details] [diff] [review]: ----------------------------------------------------------------- We should remove the l10n string from dom.properties, bit otherwise looks good.
Attachment #8725041 - Flags: review?(bkelly) → review+
https://hg.mozilla.org/mozilla-central/rev/a83057f5e96d https://hg.mozilla.org/mozilla-central/rev/7729ce5fd356
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Still present in Fennec nightly v57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: