Closed
Bug 1251887
Opened 9 years ago
Closed 9 years ago
Add break to unintentional switch fallthrough in GfxInfoBase.cpp to fix -Wimplicit-fallthrough warning
Categories
(Core :: Graphics: Canvas2D, defect)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
milan
:
review+
|
Details | Diff | Splinter Review |
| Comment hidden (obsolete) |
|
Assignee | |
Comment 1•9 years ago
|
||
clang's -Wimplicit-fallthrough warnings (not yet enabled in mozilla-central) warn about switch cases that fall through without a break or return statement. MOZ_FALLTHROUGH (bug 1215411) is an annotation to suppress -Wimplicit-fallthrough warnings where the fallthrough is intentional, but in this case, a break is enough.
widget/GfxInfoBase.cpp:158:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
Attachment #8724474 -
Attachment is obsolete: true
Attachment #8724475 -
Flags: review?(milan)
|
||
Updated•9 years ago
|
Attachment #8724475 -
Flags: review?(milan) → review+
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.