Boris Zbarsky [:bzbarsky] Assignee
	Description • 9 years ago

Now that we've done bug 1072144 we can do that.

	Bobby Holley (:bholley)
	Comment 2 • 9 years ago

Comment on attachment 8725361 [details] [diff] [review]
Make dom::WarningOnlyErrorReporter handle workers

Review of attachment 8725361 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/RuntimeService.cpp
@@ +802,5 @@
>      NS_WARNING("Could not create new context!");
>      return nullptr;
>    }
>  
> +  JS_SetErrorReporter(aRuntime, WarningOnlyErrorReporter);

Per IRC discussion, I think we should let ScriptSettings take care of this.

	Bobby Holley (:bholley)
	Comment 4 • 9 years ago

Comment on attachment 8725386 [details] [diff] [review]
Make dom::WarningOnlyErrorReporter handle workers

Review of attachment 8725386 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/base/CycleCollectedJSRuntime.cpp
@@ +502,5 @@
>                                          LargeAllocationFailureCallback, this);
>    JS_SetContextCallback(mJSRuntime, ContextCallback, this);
>    JS_SetDestroyZoneCallback(mJSRuntime, XPCStringConvert::FreeZoneCache);
>    JS_SetSweepZoneCallback(mJSRuntime, XPCStringConvert::ClearZoneCache);
> +  JS_SetErrorReporter(mJSRuntime, MozCrashErrorReporter);

Add a comment here saying that XPCJSRuntime currently override this because we don't TakeOwnership everwhere on the main thread yet.

	Pulsebot
	Comment 5 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/96580db9b356

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 9 years ago

Backed out along with the other things in the push for these failures in test_recusion.html: https://treeherder.mozilla.org/logviewer.html#?job_id=22804630&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/9716b46f3b60

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 7 • 9 years ago

I also see this failure: https://treeherder.mozilla.org/logviewer.html#?job_id=22807509&repo=mozilla-inbound

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 8 • 9 years ago

Yep, the test_ctypes.xul fail is from this bug.  Will look into it.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 9 • 9 years ago

That failure happens because we have a test for using ctypes from a worker.  And ctypes uses js::PrepareScriptEnvironmentAndInvoke, which will report exceptions itself if there is no script environment preparer.  And right now we only set up an environment preparer for XPCJSRuntime.

I'm going to push that up to CycleCollectedJSRuntime, I think.

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 10 • 9 years ago

Note that I made some changes to the EnvironmentPreparer::invoke() impl to support running it on non-main threads.  So it's not just a cut/paste job there...

	Pulsebot
	Comment 11 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc5c4cb02d24
https://hg.mozilla.org/integration/mozilla-inbound/rev/9de2c10a1cc3

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 12 • 9 years ago

Out again in https://hg.mozilla.org/integration/mozilla-inbound/rev/d7608e766470 for windows build bustage:
https://treeherder.mozilla.org/logviewer.html#?job_id=22861702&repo=mozilla-inbound

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 13 • 9 years ago

Ugh, I suck.  I left in some debugging code...  Will reland with that taken out once the tree is reopened.

	Pulsebot
	Comment 14 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/e0a06595b43c
https://hg.mozilla.org/integration/mozilla-inbound/rev/a74dae924b1f

	Carsten Book [:Tomcat]
	Comment 15 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/e0a06595b43c
https://hg.mozilla.org/mozilla-central/rev/a74dae924b1f