Closed
Bug 1252694
Opened 9 years ago
Closed 9 years ago
Set Android GCM sender ID in branding
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: nalexander, Unassigned)
References
Details
Attachments
(1 file)
Bug 1207708 added support for GCM sender IDs to the Fennec build system. In the fullness of time, I now realize that there's no need for the secrecy around sender IDs. In addition, we had plans to allow changing the sender ID dynamically, but newer GPS libraries suggest that's not the best approach. (Those libraries bake the sender ID into the Android resources directly.) Let's simplify this.
Reporter | ||
Comment 1•9 years ago
|
||
Non-Mozilla distributors may wish to run their own autopush endpoint,
using a sender ID and corresponding Google API key that they control.
This simplifies that just a little bit, and gets Mozilla's release
engineering out of the business of managing non-sensitive secrets.
In the future, this sender ID will be baked into the Android APK's
string resources, in accordance with newer Google Play Services
library requirements.
Review commit: https://reviewboard.mozilla.org/r/37499/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37499/
Attachment #8725474 -
Flags: review?(mh+mozilla)
Comment 2•9 years ago
|
||
Comment on attachment 8725474 [details]
MozReview Request: Bug 1252694 - Set MOZ_ANDROID_GCM_SENDERID directly in branding. r?glandium
https://reviewboard.mozilla.org/r/37499/#review34035
Attachment #8725474 -
Flags: review?(mh+mozilla)
Comment 3•9 years ago
|
||
Comment on attachment 8725474 [details]
MozReview Request: Bug 1252694 - Set MOZ_ANDROID_GCM_SENDERID directly in branding. r?glandium
https://reviewboard.mozilla.org/r/37499/#review34037
Sorry for the confusion, I had forgotten to check the ship-it box.
Attachment #8725474 -
Flags: review+
Comment 5•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 47 → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•