Closed Bug 1252750 Opened 9 years ago Closed 9 years ago

Enable SpecialPowers to create nested event queue and spin it

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(4 files, 4 obsolete files)

There are a number of places in our testing code that either creates a syncXHR or uses a modal dialog to spin the event loop. We should create a helper API on special powers and convert the callers. patches incoming.
Attached patch create_SpecialPowers_spinEventLoop (obsolete) (deleted) — Splinter Review
Assignee: nobody → dougt
Attachment #8725543 - Flags: review?(mrbkap)
Attached patch convert_test_geolocation (obsolete) (deleted) — Splinter Review
Attachment #8725544 - Flags: review?(mrbkap)
Attached patch convert_test_media (obsolete) (deleted) — Splinter Review
Attachment #8725545 - Flags: review?(mrbkap)
Attached patch convert_test_webspeech (obsolete) (deleted) — Splinter Review
Attachment #8725546 - Flags: review?(mrbkap)
Attachment #8725543 - Flags: review?(mrbkap) → review+
Attachment #8725544 - Flags: review?(mrbkap) → review+
Attachment #8725545 - Attachment is patch: true
Comment on attachment 8725545 [details] [diff] [review] convert_test_media Review of attachment 8725545 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/media/tests/mochitest/test_getUserMedia_spinEventLoop.html @@ +15,5 @@ > return new Promise((resolve, reject) => { > navigator.mozGetUserMedia({ audio: true }, () => { > + SpecialPowers.spinEventLoop(window); > + ok(true, "Didn't crash"); > + resolve(); Nit: It looks like the existing code had some tabs in it. Please nuke them with prejudice.
Attachment #8725545 - Flags: review?(mrbkap) → review+
Comment on attachment 8725546 [details] [diff] [review] convert_test_webspeech Review of attachment 8725546 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8725546 - Flags: review?(mrbkap) → review+
Attachment #8725543 - Attachment is obsolete: true
Attachment #8727044 - Flags: review+
Attached patch convert_test_media (deleted) — Splinter Review
Attachment #8725545 - Attachment is obsolete: true
Attachment #8727045 - Flags: review+
Attached patch convert_test_geolocation (deleted) — Splinter Review
Attachment #8725544 - Attachment is obsolete: true
Attachment #8727046 - Flags: review+
Attached patch convert_test_webspeech (deleted) — Splinter Review
Attachment #8725546 - Attachment is obsolete: true
Attachment #8727047 - Flags: review+
Keywords: checkin-needed
Blocks: 1253804
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: