Closed
Bug 1253044
Opened 9 years ago
Closed 9 years ago
3,800 instances of "unrecognized topic in PresShell::Observe" emitted from layout/base/nsPresShell.cpp during linux64 debug testing
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: erahm, Assigned: tnikkel)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
This is the top layout warning and third most verbose warning overall during testing.
> 3833 [NNNNN] WARNING: unrecognized topic in PresShell::Observe: file layout/base/nsPresShell.cpp, line 9349
This warning [1] shows up in the following test suites:
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-4-bm67-tests1-linux64-build1.txt:309
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-1-bm67-tests1-linux64-build0.txt:252
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-2-bm51-tests1-linux64-build0.txt:251
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-5-bm52-tests1-linux64-build5.txt:245
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-6-bm51-tests1-linux64-build1.txt:237
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-2-bm67-tests1-linux64-build0.txt:228
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-4-bm120-tests1-linux64-build1.txt:211
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-3-bm54-tests1-linux64-build0.txt:205
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-3-bm121-tests1-linux64-build2.txt:199
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-6-bm67-tests1-linux64-build2.txt:188
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-1-bm52-tests1-linux64-build8.txt:186
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-5-bm114-tests1-linux64-build0.txt:179
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-3-bm67-tests1-linux64-build0.txt:165
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-2-bm67-tests1-linux64-build1.txt:164
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-7-bm122-tests1-linux64-build1.txt:136
> mozilla-central_ubuntu64_vm-debug_test-mochitest-browser-chrome-7-bm123-tests1-linux64-build1.txt:129
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-1-bm116-tests1-linux64-build1.txt:117
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-4-bm115-tests1-linux64-build0.txt:110
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-7-bm51-tests1-linux64-build0.txt:109
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-5-bm116-tests1-linux64-build9.txt:77
> mozilla-central_ubuntu64_vm-debug_test-mochitest-devtools-chrome-8-bm68-tests1-linux64-build0.txt:52
> mozilla-central_ubuntu64_vm-debug_test-mochitest-other-bm67-tests1-linux64-build1.txt:33
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-browser-chrome-6-bm114-tests1-linux64-build1.txt:25
> mozilla-central_ubuntu64_vm-debug_test-mochitest-6-bm54-tests1-linux64-build0.txt:14
> mozilla-central_ubuntu64_vm-debug_test-mochitest-7-bm124-tests1-linux64-build3.txt:10
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-7-bm54-tests1-linux64-build6.txt:2
> mozilla-central_ubuntu64_vm-debug_test-mochitest-e10s-6-bm118-tests1-linux64-build0.txt:1
It shows up in 121 tests. A few of the most prevalent:
> 136 - browser/base/content/test/general/browser_wyciwyg_urlbarCopying.js
> 129 - browser/base/content/test/general/browser_zbug569342.js
> 73 - browser/components/preferences/in-content/tests/browser_subdialogs.js
> 71 - browser/extensions/loop/chrome/test/mochitest/browser_toolbarbutton.js
> 65 - browser/components/customizableui/test/browser_panel_toggle.js
> 63 - browser/components/uitour/test/browser_trackingProtection_tour.js
> 62 - browser/base/content/test/social/browser_social_window.js
> 56 - toolkit/mozapps/extensions/test/browser/test-window/browser_updateid.js
> 54 - toolkit/mozapps/extensions/test/browser/browser_updateid.js
> 54 - browser/components/extensions/test/browser/browser_ext_windows_update.js
[1] https://hg.mozilla.org/mozilla-central/annotate/c59c022943f6/layout/base/nsPresShell.cpp#l9349
|
Assignee | |
Comment 1•9 years ago
|
||
I'm guessing the reason these warnings came up is bug 1171371. So the styleset checks probably aren't to blame.
We could also just remove the warning and always return NS_OK instead of this restructuring. Not sure what's best.
Assignee: nobody → tnikkel
Attachment #8726418 -
Flags: review?(dholbert)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8726418 [details] [diff] [review]
patch
Review of attachment 8726418 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
Attachment #8726418 -
Flags: review?(dholbert) → review+
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•