Apparently the patch [1], bug 1064706, doesn't carry at least the cache load timings. This is a major telemetry and timing break. Valentin, can you please take a look and check what is missing and fix it? [1] https://bugzilla.mozilla.org/attachment.cgi?id=8500326&action=diff#a/netwerk/protocol/http/HttpChannelParent.cpp_sec3

Review commit: https://reviewboard.mozilla.org/r/37951/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/37951/

Comment on attachment 8726385 [details] MozReview Request: Bug 1253379 - Cache timings not send to HttpChannelChild r=honzab https://reviewboard.mozilla.org/r/37951/#review34517 ::: netwerk/protocol/http/TimingStruct.h:33 (Diff revision 1) > + // the rest of the timings. please say also WHY.

Comment on attachment 8726385 [details] MozReview Request: Bug 1253379 - Cache timings not send to HttpChannelChild r=honzab Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37951/diff/1-2/

Valentin, please nominate this up to beta.

Comment on attachment 8726385 [details] MozReview Request: Bug 1253379 - Cache timings not send to HttpChannelChild r=honzab Approval Request Comment [Feature/regressing bug #]: Bug 1064706 did not pass all of the timing data to the content process. [User impact if declined]: Telementry of cache timing on the content process will report wrong values. [Describe test coverage new/current, TreeHerder]: We have tests for other timings, but not cacheReadStart/End. [Risks and why]: This is low risk. It only sends the missing cacheReadStart/End timestamps to the content process. It does not change behaviour, only the data reported in the child process. [String/UUID change made/needed]: None.

Comment on attachment 8726385 [details] MozReview Request: Bug 1253379 - Cache timings not send to HttpChannelChild r=honzab Too late for 45

Comment on attachment 8726385 [details] MozReview Request: Bug 1253379 - Cache timings not send to HttpChannelChild r=honzab Fix for telemetry issue, we want good info in 46. Please uplift to beta (46 is beta now, we just did the merge an hour ago)