Closed
Bug 1253629
Opened 9 years ago
Closed 9 years ago
Adjust timeout for getFirefoxDetails()
Categories
(www.mozilla.org :: Pages & Content, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: agibson, Assigned: kohei)
References
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
We now have some GA data on our current usage of getFirefoxDetails() and it's showing on average 37% of users are falling into the "not accurate" segment, which is a lot more than expected.
I think we may not be waiting long enough for the event to return before calling the timeout here: https://github.com/mozilla/bedrock/blob/master/media/js/base/mozilla-client.js#L250
I suggest we increase it to 300ms and we'll compare the data again in a week or so.
Assignee | ||
Comment 1•9 years ago
|
||
Thanks! Sent a PR to do so.
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock
https://github.com/mozilla/bedrock/commit/d2e206983b4979a4c29821b217944a0a9ed06b32
Fix Bug 1253629 - Adjust timeout for getFirefoxDetails()
https://github.com/mozilla/bedrock/commit/efb212e1452faa9900d610bf30a9ed9ad7aad4cd
Merge pull request #3939 from kyoshino/bug-1253629-details-timeout
Fix Bug 1253629 - Adjust timeout for getFirefoxDetails()
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•