Closed
Bug 1253806
Opened 9 years ago
Closed 9 years ago
[DevTools][Memory] label.label-by > span element does not have margin-inline-end
Categories
(DevTools :: Memory, defect, P2)
DevTools
Memory
Tracking
(firefox46 affected, firefox47 affected, firefox48 fixed)
RESOLVED
FIXED
Firefox 48
People
(Reporter: magicp.jp, Assigned: bmanojkumar24, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [good first bug][lang=css][polish-backlog])
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160304030206
Steps to reproduce:
1. Start Nightly (or Aurora)
2. Open DevTools > Memory
3. Switch view from "Aggregate" to "Dominators"
Actual results:
label.label-by > span element does not have margin-inline-end
Expected results:
label.label-by > span element has margin-inline-end: 5px;
Blocks: memory-frontend
Has STR: --- → yes
status-firefox46:
--- → affected
status-firefox47:
--- → affected
Component: Untriaged → Developer Tools: Memory
OS: Unspecified → All
Hardware: Unspecified → All
Comment 1•9 years ago
|
||
Thanks once again for the bug report, :magicp! :)
To whoever would like to take this bug:
This CSS rule should also match a variant of this selector with ".label-by" instead of ".display-by": https://dxr.mozilla.org/mozilla-central/rev/b6acf4d4fc20431a8ae14bf32cdc6e43a9c0f9ad/devtools/client/themes/memory.css#90
Mentor: nfitzgerald
Priority: -- → P2
Whiteboard: [good first bug][lang=css][polish-backlog]
Comment 2•9 years ago
|
||
Sir i want to contribute to this bug. I am new contributor to mozilla. please guide me.
email:write2umeshkumhar@gmail.com
thank you
Comment 3•9 years ago
|
||
Umesh, you can follow the instructions here[0] to get a local build of firefox setup. The changes required are described in comment 1, if you have questions, feel free to ask.
I will assign the bug to you once you have attached a patch. Thanks!
[0] https://wiki.mozilla.org/DevTools/Hacking#First_Build
Comment 4•9 years ago
|
||
Sir, I just want to clear that what a patch basically contains and how and where i has to attached it.
thank you
Comment 5•9 years ago
|
||
You attach it to this bug. See also https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Assignee | ||
Comment 6•9 years ago
|
||
Hi, Can you please review the patch :D
Assignee: nobody → bmanojkumar24
Status: NEW → ASSIGNED
Attachment #8729367 -
Flags: review?(nfitzgerald)
Comment 7•9 years ago
|
||
hey
As simplyblue24 has added patch to bug. Can i still now work on bug. As a starter contributor it is good bug to work on. Am i still eligible to work on or not??
thank you
Assignee | ||
Comment 8•9 years ago
|
||
Hey umesh, you can still work on the bug, I'll unassign myself :)
Assignee: bmanojkumar24 → nobody
Status: ASSIGNED → NEW
Comment 9•9 years ago
|
||
Comment on attachment 8729367 [details] [diff] [review]
1253806.patch
Review of attachment 8729367 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8729367 -
Flags: review?(nfitzgerald) → review+
Updated•9 years ago
|
Keywords: checkin-needed
Comment 10•9 years ago
|
||
Keywords: checkin-needed
Comment 11•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment 12•9 years ago
|
||
hey nfitzgerald@mozilla.com
As you can see that simplyblue24 has unassigned himself from this bug for me to work on. And now i has solved the bug but since the patch file is same what should i do? should i submit same patch file??
thank you
Comment 13•9 years ago
|
||
You should find a new bug, since we landed simplyblue24's patch.
You can try using bugs ahoy to find a bug that's a good fit for you: http://www.joshmatthews.net/bugsahoy/
Assignee: nobody → bmanojkumar24
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•