Closed Bug 1253806 Opened 9 years ago Closed 9 years ago

[DevTools][Memory] label.label-by > span element does not have margin-inline-end

Categories

(DevTools :: Memory, defect, P2)

defect

Tracking

(firefox46 affected, firefox47 affected, firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox46 --- affected
firefox47 --- affected
firefox48 --- fixed

People

(Reporter: magicp.jp, Assigned: bmanojkumar24, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][lang=css][polish-backlog])

Attachments

(2 files)

Attached image label-by-span-margin-inline-end.png (deleted) —
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0 Build ID: 20160304030206 Steps to reproduce: 1. Start Nightly (or Aurora) 2. Open DevTools > Memory 3. Switch view from "Aggregate" to "Dominators" Actual results: label.label-by > span element does not have margin-inline-end Expected results: label.label-by > span element has margin-inline-end: 5px;
Has STR: --- → yes
Component: Untriaged → Developer Tools: Memory
OS: Unspecified → All
Hardware: Unspecified → All
Thanks once again for the bug report, :magicp! :) To whoever would like to take this bug: This CSS rule should also match a variant of this selector with ".label-by" instead of ".display-by": https://dxr.mozilla.org/mozilla-central/rev/b6acf4d4fc20431a8ae14bf32cdc6e43a9c0f9ad/devtools/client/themes/memory.css#90
Mentor: nfitzgerald
Priority: -- → P2
Whiteboard: [good first bug][lang=css][polish-backlog]
Sir i want to contribute to this bug. I am new contributor to mozilla. please guide me. email:write2umeshkumhar@gmail.com thank you
Umesh, you can follow the instructions here[0] to get a local build of firefox setup. The changes required are described in comment 1, if you have questions, feel free to ask. I will assign the bug to you once you have attached a patch. Thanks! [0] https://wiki.mozilla.org/DevTools/Hacking#First_Build
Sir, I just want to clear that what a patch basically contains and how and where i has to attached it. thank you
Attached patch 1253806.patch (deleted) — Splinter Review
Hi, Can you please review the patch :D
Assignee: nobody → bmanojkumar24
Status: NEW → ASSIGNED
Attachment #8729367 - Flags: review?(nfitzgerald)
hey As simplyblue24 has added patch to bug. Can i still now work on bug. As a starter contributor it is good bug to work on. Am i still eligible to work on or not?? thank you
Hey umesh, you can still work on the bug, I'll unassign myself :)
Assignee: bmanojkumar24 → nobody
Status: ASSIGNED → NEW
Comment on attachment 8729367 [details] [diff] [review] 1253806.patch Review of attachment 8729367 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8729367 - Flags: review?(nfitzgerald) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
hey nfitzgerald@mozilla.com As you can see that simplyblue24 has unassigned himself from this bug for me to work on. And now i has solved the bug but since the patch file is same what should i do? should i submit same patch file?? thank you
You should find a new bug, since we landed simplyblue24's patch. You can try using bugs ahoy to find a bug that's a good fit for you: http://www.joshmatthews.net/bugsahoy/
Assignee: nobody → bmanojkumar24
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: