Closed Bug 1254117 Opened 9 years ago Closed 8 years ago

Move rules to generate nsCSSPropsGenerated.inc into GENERATED_FILES Python script

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1272488

People

(Reporter: ted, Unassigned)

References

(Blocks 1 open bug)

Details

We generate nsCSSPropsGenerated.inc as part of the build: https://hg.mozilla.org/mozilla-central/file/e7319545eb3819da67ffe1d4233022ae71e3a9a1/layout/style/moz.build#l241 https://hg.mozilla.org/mozilla-central/file/e7319545eb3819da67ffe1d4233022ae71e3a9a1/layout/style/Makefile.in#l16 and in fact we already use a Python script for it: https://hg.mozilla.org/mozilla-central/file/e7319545eb3819da67ffe1d4233022ae71e3a9a1/layout/style/GenerateCSSPropsGenerated.py The only fiddly bit here is that currently we feed PythonCSSProps.h through the C preprocessor as input. We can't replace that with the Python preprocessor, it really does use C preprocessor tricks. We should be able to switch this to using a GENERATED_FILES Python script though, and just have that shell out to the C preprocessor. It shouldn't be a huge change to the existing script.
Apparently I didn't see this bug when making bug 1272488.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.