Closed
Bug 1254169
Opened 9 years ago
Closed 9 years ago
Migrate Keyboard to use L20n
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zbraniecki, Assigned: zbraniecki)
References
Details
Attachments
(1 file)
Keyboard is used by the TV, is maintained and is using deprecated l10n.js.
Let's migrate it to l20n
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → gandalf
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8727558 [details]
[gaia] zbraniecki:1254169-migrate-keyboard-to-l20n > mozilla-b2g:master
Tim, can you review this for me?
Attachment #8727558 -
Flags: review?(timdream)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8727558 [details]
[gaia] zbraniecki:1254169-migrate-keyboard-to-l20n > mozilla-b2g:master
Please remove the es6 syntax before merging, thanks!
It looks like we assume LayoutItemView#_getHumanFileSize is safe without run to completion -- the promise won't execute callback out-of-order, is it? If so, let's ignore it.
Attachment #8727558 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•9 years ago
|
||
Could you merge a follow-up commit and remove the use of arrow functions too (only in the code, not in the tests).
We want to avoid es6 for the same reason... thanks.
Flags: needinfo?(gandalf)
|
|
Assignee | |
Comment 6•9 years ago
|
||
Oh, I wrote the patch, and somehow it didn't get to the branch before merging, sorry!
Landed: https://github.com/mozilla-b2g/gaia/commit/cee2b43ffff073399a7c5629cda2776b61ccbb6b
Flags: needinfo?(gandalf)
You need to log in
before you can comment on or make changes to this bug.
Description
•