Closed
Bug 1254305
Opened 9 years ago
Closed 9 years ago
addOptions method takes 3 arguments, 4 given
Categories
(Instantbird Graveyard :: Account manager, defect)
Instantbird Graveyard
Account manager
Tracking
(Not tracked)
RESOLVED
FIXED
Instantbird 48
People
(Reporter: aryx, Assigned: abdelrahman)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
addOptions takes 3 arguments: https://hg.mozilla.org/comm-central/annotate/874977941872aab3e7a198fa3912d7c73d7e5a85/chat/content/imAccountOptionsHelper.js#l56
> addOptions: function(aIdPrefix, aOptions, aAttributes) {
But here 4 arguments are given: https://hg.mozilla.org/comm-central/rev/2f6efb061544#l3.105
> accountOptionsHelper.addOptions(this.proto.id + "-", this.getProtoOptions(),
> null, this.prefs);
Updated•9 years ago
|
Flags: needinfo?(ab)
Assignee | ||
Comment 1•9 years ago
|
||
Oh, thanks for discovering that.
Assignee: nobody → ab
Status: NEW → ASSIGNED
Flags: needinfo?(ab)
Comment 2•9 years ago
|
||
Comment on attachment 8728125 [details] [diff] [review]
patch
Review of attachment 8728125 [details] [diff] [review]:
-----------------------------------------------------------------
am-im.js has too many parameters too.
Attachment #8728125 -
Flags: review-
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8728125 -
Attachment is obsolete: true
Attachment #8728150 -
Flags: review?(aleth)
Updated•9 years ago
|
Attachment #8728150 -
Flags: review?(aleth) → review+
Updated•9 years ago
|
Keywords: checkin-needed
Comment 4•9 years ago
|
||
Thanks! https://hg.mozilla.org/comm-central/rev/5aff4df43e18
Does this need to be uplifted?
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(ab)
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 48
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Patrick Cloke [:clokep] from comment #4)
> Thanks! https://hg.mozilla.org/comm-central/rev/5aff4df43e18
>
> Does this need to be uplifted?
I do not think so as the method is called in both cases and the order of passed parameters is same so nothing will be passed wrongly.
Flags: needinfo?(ab)
You need to log in
before you can comment on or make changes to this bug.
Description
•