Closed
Bug 1254643
Opened 9 years ago
Closed 8 years ago
Try to delete FxA device IDs when Fennec Firefox Accounts are removed from the device
Categories
(Firefox for Android Graveyard :: Firefox Accounts, defect, P1)
Firefox for Android Graveyard
Firefox Accounts
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: nalexander, Assigned: eoger)
References
Details
Attachments
(1 file)
This will be follow-up (or part of) Bug 1250782. This ticket tracks adding code to https://dxr.mozilla.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/fxa/receivers/FxAccountDeletedService.java#40 to HTTP DELETE the relevant FxA device ID, if we can. At that point we should have access to the FxA authToken, so we can actually authenticate. I suppose this assumes the account is healthy, so we can get the authToken; if we can't, or the authentication fails, we can't make progress, so just give up.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1250782#c3.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Priority: -- → P1
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8846784 [details]
Bug 1254643 - Delete FxA device when Fennec Firefox Account is removed.
https://reviewboard.mozilla.org/r/119790/#review122178
LGTM, patch seems to mimick how we do other fxaclient interactions (I haven't actually tested it locally). It seems to me that these kinds of actions should be side-effects of FxA state machine transitions, but it doesn't seem like a well isolated sort of a thing that is easy to change, so I'm OK with this for now.
::: mobile/android/services/src/main/java/org/mozilla/gecko/fxa/receivers/FxAccountDeletedService.java:78
(Diff revision 1)
> Logger.warn(LOG_TAG, "Intent malformed: no account name given. Not cleaning up after " +
> "deleted Account.");
> return;
> }
>
> + // Delete current device from the FxA list
nit: full sentence, "Delete current device the from FxA devices list."
::: mobile/android/tests/background/junit4/src/org/mozilla/gecko/fxa/login/MockFxAccountClient.java:206
(Diff revision 1)
> requestDelegate.handleError(e);
> }
> }
>
> @Override
> + public void destroyDevice(byte[] sessionToken, String deviceId, RequestDelegate<ExtendedJSONObject> requestDelegate) {
Is this actually used by any of the tests?
Attachment #8846784 -
Flags: review?(gkruglov) → review+
Assignee | ||
Comment 3•8 years ago
|
||
mozreview-review-reply |
Comment on attachment 8846784 [details]
Bug 1254643 - Delete FxA device when Fennec Firefox Account is removed.
https://reviewboard.mozilla.org/r/119790/#review122178
> Is this actually used by any of the tests?
No, but since this is an interface we have to implement the method, so might as well do it right instead of throwing UnsupportedOperationException :)
Comment hidden (mozreview-request) |
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb2f75b195e8
Delete FxA device when Fennec Firefox Account is removed. r=Grisha
Comment 6•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•