Closed
Bug 1254657
Opened 9 years ago
Closed 9 years ago
Fix issue with sending of Content:LoadURIResult
Categories
(Firefox :: Address Bar, defect)
Tracking
()
RESOLVED
FIXED
Firefox 48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
Attachments
(1 file)
RemoteWebProgress is currently sad because aMessage.json is null. Per discussion with mconley, we should treat the Content:LoadURIResult message specially and avoid the main switch statement for it, and just bail out quickly.
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/38765/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38765/
Attachment #8728040 -
Flags: review?(mconley)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8728040 [details]
MozReview Request: Bug 1254657 - change how we send Content:LoadURIResult to avoid upsetting RemoteWebProgress.jsm, r?mconley
https://reviewboard.mozilla.org/r/38765/#review35421
LGTM - well spotted!
::: toolkit/modules/RemoteWebProgress.jsm:187
(Diff revision 1)
> + if (aMessage.name == "Content:LoadURIResult") {
Maybe add a quick comment here saying that this is intentionally separated from the switch statement because it doesn't need to call any progress listeners, or something along those lines.
Attachment #8728040 -
Flags: review?(mconley) → review+
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in
before you can comment on or make changes to this bug.
Description
•