Closed Bug 1254855 Opened 9 years ago Closed 9 years ago

Switch the AutoEntryScripts in nsDirectoryViewer to take ownership of error reporting

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

No description provided.
These are both in things that get called from the event loop, so there is no one to report if we don't.
Attachment #8728246 - Flags: review?(bobbyholley)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8728246 [details] [diff] [review] Switch AutoEntryScripts in nsDirectoryViewer to take ownership of error reporting Review of attachment 8728246 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Boris Zbarsky [:bz] from comment #1) > Created attachment 8728246 [details] [diff] [review] > Switch AutoEntryScripts in nsDirectoryViewer to take ownership of error > reporting > > These are both in things that get called from the event loop, so there is no > one to report if we don't. To be clear (here and in other bugs), the legacy error reporting mechanism currently handles these things, so they're not getting dropped on the floor. I'm presuming you're aware of that, and that these comments are meant to say "we're not stepping on anyone's toes by taking ownership", but I just thought it was worth making explicit.
Attachment #8728246 - Flags: review?(bobbyholley) → review+
> To be clear (here and in other bugs), the legacy error reporting mechanism currently handles these things Oh, because we don't have script on the stack? That's a good point; I had in fact missed that. I'll fix the commit messages.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: