Closed
Bug 1254884
Opened 9 years ago
Closed 9 years ago
Can't use booleans in set_config() or set_define()
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: glandium, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Adding, for instance set_define('SPIDERMONKEY_PROMISE', True) fails with:
0:06.06 js/src> File "./config.status", line 433, in <module>
0:06.06 js/src> "SPIDERMONKEY_PROMISE": true,
0:06.06 js/src> NameError: name 'true' is not defined
|
||
Comment 1•9 years ago
|
||
The way we're writing config.status means everything we put in the config needs to JSON serialize to valid Python.
We could add a special case convert True to '1', or just have set_config or set_define with one argument mean the corresponding value ends up in the config as '1' to make this more convenient to write.
|
Reporter | |
Comment 2•9 years ago
|
||
I was thinking adding something like: true, false, null = True, False, None
|
|
Reporter | |
Comment 3•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40257/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40257/
Attachment #8730943 -
Flags: review?(cmanchester)
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8730943 [details]
MozReview Request: Bug 1254884 - Make JSON serialization to config.status more readable as python
https://reviewboard.mozilla.org/r/40257/#review36791
Sure.
Attachment #8730943 -
Flags: review?(cmanchester) → review+
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•