Closed
Bug 1254923
Opened 9 years ago
Closed 9 years ago
Remove RemoveAllPages API
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: mak, Assigned: tvaleev, Mentored)
References
Details
(Whiteboard: [good first bug][lang=cpp])
Attachments
(1 file)
|
(deleted),
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
RemoveAllPages was deprecated in Firefox 45, we should remove it from Firefox 48 on
http://mxr.mozilla.org/mozilla-central/search?string=removeallpages
(ignoring the puppeteer piece that will be fixed in bug 1249259
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → tvaleev
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8728471 [details] [diff] [review]
bug-1254923-fix.patch
Review of attachment 8728471 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you it looks good.
We just have to wait for the dependency bug to land first, then we can land this.
Attachment #8728471 -
Flags: review?(mak77) → review+
|
|
Reporter | |
Updated•9 years ago
|
Flags: needinfo?(mak77)
|
|
Reporter | |
Comment 3•9 years ago
|
||
this is a plain removal of a not used API, so I'm not triggering a try run for it, since it would be a waste of resources.
Keywords: checkin-needed
|
|
Reporter | |
Updated•9 years ago
|
Flags: needinfo?(mak77)
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•