Closed
Bug 1255222
Opened 8 years ago
Closed 8 years ago
Use InputConnection#getHandler() to run InputConnection on a separate thread for Android N+
Categories
(Firefox for Android Graveyard :: Keyboards and IME, defect)
Tracking
(firefox49 fixed)
RESOLVED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: yukawa, Assigned: jchen)
References
Details
Attachments
(1 file)
(deleted),
patch
|
esawin
:
review+
|
Details | Diff | Splinter Review |
Just for a heads up, in Android Framework team I'm working for introducing a new API (it's still an API candidate though) InputConnection#getHandler() for Android N so that application developers can receive InputConnection callbacks on an arbitrary Handler rather than view.getHandler() without unreliable hacks like Bug 835906 and http://crbug.com/551193. Although the API document is not available online yet, you can download the zip archive from here. http://developer.android.com/preview/setup-sdk.html#docs-dl If everything is working as expected you should already be able to use InputConnection#getHandler() with the first Android N developer preview NPC56P. If you find any issues please feel free to ping me (on this thread). Thanks!
Reporter | ||
Updated•8 years ago
|
OS: Unspecified → Android
Hardware: Unspecified → All
Updated•8 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(snorp)
Flags: needinfo?(nchen)
Comment 1•8 years ago
|
||
NI Jim or Snorp to comment on this. It would be good to document our needs from such an API.
Interesting! Yohei, we'll try to look at this, but it may take a while. Thanks for the heads up. Jim, if you have a chance this might be fun to play with.
Flags: needinfo?(snorp)
Assignee | ||
Comment 3•8 years ago
|
||
The API looks like it should be straightforward to implement.
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Flags: needinfo?(nchen)
Assignee | ||
Comment 4•8 years ago
|
||
Implement the new InputConnection.getHandler method for running input methods on a separate thread in Android N.
Attachment #8747949 -
Flags: review?(esawin)
Comment 5•8 years ago
|
||
Comment on attachment 8747949 [details] [diff] [review] Implement InputConnection.getHandler for Android N (v1) Review of attachment 8747949 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8747949 -
Flags: review?(esawin) → review+
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6b4ca99fc5f5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 8•8 years ago
|
||
We're working with a partner and we'd like to get solid Android N support in Firefox 48. Is this something that can be easily uplifted?
Updated•8 years ago
|
Flags: needinfo?(nchen)
Assignee | ||
Comment 9•8 years ago
|
||
Yep! It's a fairly trivial patch, but I think it still needs more extensive testing on N. It's also not strictly necessary for N support. Let me know if you want me to go ahead and request uplift.
Flags: needinfo?(nchen)
Comment 10•8 years ago
|
||
If it doesn't specifically help us on Android N, I wouldn't worry about it.
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•