Unfortunately we can't remove all of SEC_NORMAL from browser/ right now, e.g. Bug 1232432 is blocked on the docshell changes, but we can't convert all the ones that use the systemPrincipal as the loadingPrincipal.

Comment on attachment 8729086 [details] [diff] [review] bug_1255499_remove_sec_normal_browser.patch Review of attachment 8729086 [details] [diff] [review]: ----------------------------------------------------------------- Probably worth splitting this up into two bugs and checking in the MozLoopPushHandler changes right away. We probably need to audit calls of asyncFetch globally :( ::: browser/modules/WindowsPreviewPerTab.jsm @@ +83,5 @@ > channel.setPrivate(privateMode); > } catch (e) { > // Ignore channels which do not support nsIPrivateBrowsingChannel > } > NetUtil.asyncFetch(channel, function(inputStream, resultCode) { Should we add asyncFetch2? Seems like we should do more than just switch the newChannel call here.

(In reply to Jonas Sicking (:sicking) from comment #3) > Should we add asyncFetch2? Seems like we should do more than just switch the > newChannel call here. I filed Bug 1257930 to udpate that.

Jonas, the MozLoopPushHandler changes already landed within Bug 1257924 and we updated asyncFetch to be able to handle asyncOpen2() within Bug 1257930. This is ready to land but still blocked on the imgLoader changes obviously.