Closed
Bug 1255527
Opened 9 years ago
Closed 9 years ago
remove sutagent/watcher code from source tree
Categories
(Testing Graveyard :: SUTAgent, defect)
Testing Graveyard
SUTAgent
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: jmaher, Assigned: gbrown)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
now that android 2.3 is deprecated we do not have android tests running sutagent/watcher code anymore.
Assignee | ||
Comment 1•9 years ago
|
||
fencp, ffxcp, everything under build/mobile/sutagent can go.
Depends on: 1250994
Assignee | ||
Comment 2•9 years ago
|
||
DeviceManagerSUT is still used with Negatus for steeplechase -- DeviceManagerSUT cannot be eliminated.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → gbrown
Assignee | ||
Comment 3•9 years ago
|
||
Android 2.3 builds and tests no longer run on trunk trees - bug 1250999.
No harm done by removing sutagent:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a431c609398
Attachment #8730503 -
Flags: review?(jmaher)
Reporter | ||
Comment 4•9 years ago
|
||
Comment on attachment 8730503 [details] [diff] [review]
remove sutagent
Review of attachment 8730503 [details] [diff] [review]:
-----------------------------------------------------------------
we should ensure there is no code in buildbot or autophone that depends on these .apk files existing. I didn't see any on a simple look.
Attachment #8730503 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 5•9 years ago
|
||
I checked hg.mozilla.org/build and autophone. There are a few references to sutagent in comments and such, and DeviceManagerSUT-like code, but I don't see any evidence of code actually using sutagent, watcher, or fencp.
Comment 7•9 years ago
|
||
I still see references to the sut in the dm specification, ...
testing/mochitest/mochitest_options.py: {"choices": ["adb", "sut"],
testing/mochitest/mochitest_options.py: elif options.dm_trans == 'sut':
Should we start removing references to it elsewhere?
Assignee | ||
Comment 8•9 years ago
|
||
:ted -- The other day you noted that Steeplechase uses DeviceManagerSUT and Negatus. Do we also need (or want) to continue support for the dm_trans option in test harnesses?
Flags: needinfo?(ted)
Comment 9•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 10•9 years ago
|
||
(In reply to Geoff Brown [:gbrown] from comment #8)
> :ted -- The other day you noted that Steeplechase uses DeviceManagerSUT and
> Negatus. Do we also need (or want) to continue support for the dm_trans
> option in test harnesses?
Steeplechase does use dmSUT and Negatus, yes, since its whole purpose is to run things on different machines. As to whether you support those in other harnesses I have no opinion.
Flags: needinfo?(ted)
Updated•7 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•