the Cache prefs panel is now clipped on the right side --at least the buttons are. seen on: * mac 10.1.2 - aqua/classic theme only [2002.02.14.08] * mac 9.1 - modern and classic themes [2002.02.14.08] * linux rh7.2 - modern and classic thems [2002.02.13.08] not seen on win2k, either theme.

ben who should own this? your suggestions? per adt, not critical for nsbeta1. hence minus.

renominating --that is, i thought we wanted to avoid the panel clipping issues. moreover, this is a regression: this is fine with 2/7, but regressed with 2/11 builds. who checked in stuff during that period that would've caused this?

nsbeta1- per Nav triage team

*** Bug 124978 has been marked as a duplicate of this bug. ***

*** Bug 131621 has been marked as a duplicate of this bug. ***

*** Bug 138831 has been marked as a duplicate of this bug. ***

Mozilla build 2002041711 Mac OS 9.2.2 Preferences Classic Theme Mail & Newsgroups - Message Display Text clipped at bottom of Panel, Style and Size buttons different widths, Size button clipping label. Modern Theme Mail & Newsgroups - Send Format Domain boxes and Delete buttons Clipped by panel bottom Privacy A Security - Master Passwords Reset button clipped by panel bottom

*** Bug 139537 has been marked as a duplicate of this bug. ***

*** Bug 149384 has been marked as a duplicate of this bug. ***

i spoke w/ fantasai on #mozui and we came up with this wording. notes: some text belongs in help, not the pref dialog. I intend to file bugs about that. fantasai suggested that Location be indented, i tried to do that in this patch, but it's untested.

Comment on attachment 90827 [details] [diff] [review] first pass r=Kowalski

*** Bug 130353 has been marked as a duplicate of this bug. ***

nominating. how does the patch look?

*** Bug 149611 has been marked as a duplicate of this bug. ***

Comment on attachment 90827 [details] [diff] [review] first pass > Index: content/pref-cache.xul >... How to fix this bug in two easy steps: (1) Get rid of the group box around the entire panel. It's completely useless, since it's not separating the panel's contents from anything. (2) Change `Disk Cache Folder:' to `Cache Folder:'. That a folder is on disk is basically a tautology. For bonus points, if you're feeling energetic: (3) fix the alignment of the text field labels (the `:'s should be lined up with each other); (4) remove the strange indenting from the `Compare the page in the cache to the page on the network:' option buttons. >... >- <label value="&diskCacheFolder.label;"/> >+ <hbox class="ident"> >+ <label value="&diskCacheFolder.label;"/> >+ </hbox> If that does what I think it does (is `ident' supposed to be `indent'?), please don't do it. >... > Index: locale/en-US/pref-cache.dtd >... > -<!ENTITY cachePara "The cache keeps copies of frequently visited web pages on your hard disk. This reduces the amount of time you are connected to the Internet. (Clicking Reload always shows you the latest version of a page.)"> > +<!ENTITY cachePara "Cache stores pages you visit for quicker access when you return. (Reload will get a fresh copy.)"> Cache isn't a proper noun, so you do need to precede it with an article (`The cache'). I suggest: `The cache stores recently visited files for fast loading.' (The stuff about Reload should be removed, because it's non-trivially untrue, and there's not enough room to make it true.) >... > -<!ENTITY clearMemCache.label "Clear Memory Cache"> > +<!ENTITY clearMemCache.label "Clear"> > <!ENTITY clearMemCache.accesskey "c"> > -<!ENTITY clearDiskCache.label "Clear Disk Cache"> > +<!ENTITY clearDiskCache.label "Clear"> > <!ENTITY clearDiskCache.accesskey "l"> That would be sub-optimal. `Delete Files' would be more reassuring, and still shorter than `Clear Disk Cache'. The rest of the changes look good, though it's a bit hard to tell without a screenshot.

I have changed the layout of the cache preferences panel under the auspices of bug 46490 while adding a button to reset the cache location to the cache prefs panel. This is a screenshot of the cache panel with my patch applied. I am posting here because I believe that my patch might well fix this bug at no additional cost. I do not get a clipped prefs panel either way, so somebody else will have to verify this, but I am quite sure it should work. Here's why: At the moment the widest part of the cache prefs panel is this part: Disk Cache Folder: (/path/to/my/cache/folder) [Choose Folder] With my patch applied this will look like this: Disk Cache Folder: (/path/to/my/cache/folder) [Restore Default][Choose Folder] Just have a look at both screenshots and compare, it should further illustrate the point. I shrunk my prefs panel a bit to show that the text field is variable length and now the widest part of the panel. Doesn't this look like a match made in heaven ;-)? A fix for a nasty polish bug included in a patch that has been sitting in bugzilla awaiting review for 4 months already? So why duplicate the effort and let my patch contract a serious case of bitrot? Just point your browsers at http://bugzilla.mozilla.org/attachment.cgi?id=78128&action=view please check out my patch and maybe even give me reviews, I have been hunting up and down for those for quite some time. If modifications are necessary or if you wish to have the layout change separated from the "Restore Default" button, I can do that. I could also do some of the stuff mpt suggested like aligning the ":"s of the labels etc.

it won't fit. it barely fits on unix. and on macos things take up more space. feel free to integrate my patch, your patch and mpt's comments.

Timeless, did you try my patch? Could you post a screen shot of the clipped panel with my patch applied? OK, I will rework and extend my patch. I think I might squeeze in an hour tomorrow or in the next days.

here's a better image of what you're up against. you can take as long as you want trying to explain how adding height to the dialog will fix its horizontal problems. but .. it won't work, since we don't fit in *either* direction in modern :-) ... o ye of little faith.

I'm seeing this problem on the mac os9x in not only the cache prefs but in a number of other pref windows. (Navigator for one) No problems with osX, or linux for me.

ok, timeless pointed out the meta bug to me. Please ignore my last post.

*** Bug 163229 has been marked as a duplicate of this bug. ***

I finished my patch over in bug 46490 and we need to settle who goes in first. I suggest committing my patch first since it might regress this bug as it changes the layout of the cache preferences panel. A comment on the subject in bug 46490 would be very much appreciated because my r= and sr= hinge on resolving which patch should be committed first.

nsbeta1+/adt3 per the nav triage team.

*** Bug 182485 has been marked as a duplicate of this bug. ***

attachment 107697 [details] shows the same clipping problem on windows w/ large fonts.

*** Bug 184164 has been marked as a duplicate of this bug. ***

Over to Shuehan.

moved the choose folder button to a new row and removed a separator sarah has tested this and it works for all platforms

Comment on attachment 110030 [details] [diff] [review] patch looks good, r=varga

Comment on attachment 110030 [details] [diff] [review] patch sr=jag

fixed

This is under Mac OS 9.1.

Hmm, does this matter now that OS9 has been relegated to port status?

vrfy'd fixed with 2003.02.10 comm trunk builds on win2k and linux rh8.0.

also fine on mac os x 10.2.3.