Closed Bug 1255707 Opened 9 years ago Closed 9 years ago

Remove ContentCreationNotifier from Android widget

Categories

(Core Graveyard :: Widget: Android, defect)

Product:
Core Graveyard
Component:
Widget: Android
Platform:
Unspecified
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox48 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(2 files)

MozReview Request: Bug 1255707 - Part 1. Remove ContentCreationNotifier. r?snorp
(deleted), text/x-review-board-request
snorp
: review+
Details
MozReview Request: Bug 1255707 - Part 2. Remove ScreenSizeChanged. r?snorp
(deleted), text/x-review-board-request
snorp
: review+
Details
ContentCreationNotifier into widget/android/nsWindow.cpp was e10s-era code by bug 600880. We never use this code since Fennec/Android is single process now.
Assignee: nobody → m_kato
ContentCreationNotifier was for bug 600880. But Fennec is not e10s now, so this is unnecessary. Review commit: https://reviewboard.mozilla.org/r/39667/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/39667/
Attachment #8730112 - Flags: review?(snorp)
SceenSizeChanged IPC was for bug 600880. No one uses it. Review commit: https://reviewboard.mozilla.org/r/39669/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/39669/
Attachment #8730113 - Flags: review?(snorp)
Comment on attachment 8730112 [details] MozReview Request: Bug 1255707 - Part 1. Remove ContentCreationNotifier. r?snorp https://reviewboard.mozilla.org/r/39667/#review36355 We actually want to look into enabling e10s again on Android, so I think we should leave this in for now
Attachment #8730112 - Flags: review?(snorp)
Comment on attachment 8730113 [details] MozReview Request: Bug 1255707 - Part 2. Remove ScreenSizeChanged. r?snorp https://reviewboard.mozilla.org/r/39669/#review36357 Same deal as the other patch -- we should leave it for now, since e10s is something we want to try to get back to.
Attachment #8730113 - Flags: review?(snorp)
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #3) > Comment on attachment 8730112 [details] > MozReview Request: Bug 1255707 - Part 1. Remove ContentCreationNotifier. > r?snorp > > https://reviewboard.mozilla.org/r/39667/#review36355 > > We actually want to look into enabling e10s again on Android, so I think we > should leave this in for now OK, But we should use GetXPCOMProcessAttributes to initialize and set content process information instead of ContentCreationNotifier. It can reduce observers.
Also, this code is unused after bug 1182665...
Depends on: 1182665
Comment on attachment 8730112 [details] MozReview Request: Bug 1255707 - Part 1. Remove ContentCreationNotifier. r?snorp Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39667/diff/1-2/
Attachment #8730112 - Flags: review?(snorp)
Comment on attachment 8730113 [details] MozReview Request: Bug 1255707 - Part 2. Remove ScreenSizeChanged. r?snorp Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39669/diff/1-2/
Attachment #8730113 - Flags: review?(snorp)
GetAndroidScreenBounds is no longer used after bug 1182665. So ContentCreationNotifier and ScreenSizeChanged IPC are unnecessary even if e10s.
Comment on attachment 8730112 [details] MozReview Request: Bug 1255707 - Part 1. Remove ContentCreationNotifier. r?snorp https://reviewboard.mozilla.org/r/39667/#review36573
Attachment #8730112 - Flags: review?(snorp) → review+
Comment on attachment 8730113 [details] MozReview Request: Bug 1255707 - Part 2. Remove ScreenSizeChanged. r?snorp https://reviewboard.mozilla.org/r/39669/#review36575
Attachment #8730113 - Flags: review?(snorp) → review+
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: