Closed Bug 1256010 Opened 9 years ago Closed 7 years ago

Remove media/openmax_dl/dl/Makefile.in

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox58 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: ted, Assigned: ted)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

bug 1256010 - Remove media/openmax_dl/dl/Makefile.in.
(deleted), text/x-review-board-request
nalexander
: review+
Details
This Makefile unsets VISIBILITY_FLAGS for Windows builds: https://hg.mozilla.org/mozilla-central/file/31481f9ebdda792e0ec01d8a007de8b193bc206f/media/openmax_dl/dl/Makefile.in ...but the code only gets built for arm platforms: https://hg.mozilla.org/mozilla-central/file/31481f9ebdda792e0ec01d8a007de8b193bc206f/media/openmax_dl/dl/moz.build We should just remove this makefile. While we're there, there's an extraneous moz.build file as well containing nothing but DIRS: https://hg.mozilla.org/mozilla-central/file/31481f9ebdda792e0ec01d8a007de8b193bc206f/media/openmax_dl/moz.build We could just make this DIRS line point directly to '/media/openmax_dl/dl/': https://dxr.mozilla.org/mozilla-central/rev/946ed22cad04431c75ab5093989dfedf1bae5a3e/config/external/moz.build#40
Attachment #8926505 - Flags: review?(core-build-config-reviews)
Attachment #8926505 - Flags: review?(core-build-config-reviews)
Assignee: nobody → ted
Pushed by tmielczarek@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e72bc4c1935 Remove media/openmax_dl/dl/Makefile.in. r=nalexander
https://hg.mozilla.org/mozilla-central/rev/2e72bc4c1935
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: