Build: N6.2.1 and 02-14 trunk build Go a GB18030 page here: http://babel/testdata/Double_byte/gb18030/gb18030.html And turn auto-detect to All. Simp. Chinese, Chinese, East Asian, the charset will pick up the wrong charset, e.g. MacRoman, western ISO-1252..etc.

auto-detect guru -> shanjian

this patch added gb18030 to Chinese/CJK detector. (Universal is not included yet.) I found another problem when testing this patch. GB18030 is not correctly marked in charset menu. This might be a different problem, but I need to find out why.

nsbeta1+ for all the detector mentioned above

frank, could you r=?

Comment on attachment 70588 [details] [diff] [review] patch ready for r/sr the state machine looks right. r=ftang

brendan, could you sr?

cc to shaver. Shaver, could you sr?

Comment on attachment 70588 [details] [diff] [review] patch ready for r/sr >Index: src/nsGB18030Verifier.h >+static nsVerifier nsgb18030Verifier = { >+ "gb18030", >+ { >+ eIdxSft4bits, >+ eSftMsk4bits, Odd mixed-bracing style here: cuddled for outer struct, uncuddled for inner. >+}; >\ No newline at end of file You need to have newlines on the ends of files, or some compilers will die. >+#!/usr/local/bin/perl perl may not be in /usr/local/bin. Please use env or one of the canonical re-execing tricks for locating perl in the path. (The "perlrun" man page should have details.)

>>Odd mixed-bracing style here: cuddled for outer struct, >>uncuddled for inner. The file was auto generated by perl script. Personally I don't think it is odd. For consistency, I don't want to just change this file. To regenerate every files might be risky at this point. Some of the files might be manually adjusted. >>You need to have newlines on the ends of files, or some compilers >>will die. There is newline in my local file. I don't know why diff complains. It works well with all other files (generated by similar perl script). >>perl may not be in /usr/local/bin. Please use env or one of the >>canonical re-execing tricks for locating perl in the path. >>(The "perlrun" man page should have details.) Those perl scripts are just one time tools to generate those header files, but not part of the build. They were put there for future reference and extension.

Comment on attachment 70588 [details] [diff] [review] patch ready for r/sr Fair enough. Can you add some of your warnings about using this script to regenerate tables (which may be hand-edited, etc.) as a comment in the perl script? That would make me feel safe and warm. sr=shaver.

Mike, if I understood what you mean "warning" correctly, such comment already exists in perl script, and thus also the generated header file.

Comment on attachment 70588 [details] [diff] [review] patch ready for r/sr a=asa (on behalf of drivers) for checkin to the 1.0 trunk

fix checked in.

Fixed verified on 03-18 trunk build, everything works fine except auto-detect All which handled by another bug, mark this as verified.