Bug 1252481 removes the "sum_squares_lo" and "sum_squares_hi" properties from Telemetry. Without those, the additional stats collection in histogram.cc actually never gets used. This is basically all the additional code that was added here: https://hg.mozilla.org/mozilla-central/rev/4e8386f13286 To verify this did not break anything, we should run the tests using: mach test toolkit/components/telemetry/tests/unit

(In reply to Georg Fritzsche [:gfritzsche] from comment #0) > Without those, the additional stats collection in histogram.cc actually > never gets used. > This is basically all the additional code that was added here: > https://hg.mozilla.org/mozilla-central/rev/4e8386f13286 To add a bit of detail: For histogram.h & histogram.cc, we can: * drop all the sum_squares, log_sum, log_sum_squares occurrences and their calculations * we don't need AccumulateWithLinearStats(), we can just use Accumulate() directly * note that current code looks a bit difference now than in the revision linked above

malayaleecoder, are you interested in taking this follow-up bug to bug 1252481?

Sure Georg, I am taking this :)

Hey malayaeecoder, did you have success working on this? Let me know if you're stuck, i'm happy to help.

Hello Georg, Please have a look at the patch. I smell something wrong even though the build went through fine.

Please ignore the previous patch.

Comment on attachment 8737701 [details] [diff] [review] Bug1256366_v1.diff Review of attachment 8737701 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me, thanks! Julian, would you mind taking a quick look at the mutex usage for correctness?

Comment on attachment 8737701 [details] [diff] [review] Bug1256366_v1.diff Review of attachment 8737701 [details] [diff] [review]: ----------------------------------------------------------------- Yes, that looks fine to me. Does not look as if it will change the locking situation at all.

Georg the try push seems good. Adding checkin-needed , hope it is fine.

Sure, thanks!