Closed
Bug 1256411
Opened 9 years ago
Closed 9 years ago
simplify and cleanup ServiceWorkerInfo
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ehsan.akhgari
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
While working on other bugs I noticed some things we can simplify in ServiceWorkerInfo. Some dead code and unnecessarily complex object dependencies.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8730343 -
Flags: review?(ehsan)
|
||
Updated•9 years ago
|
Attachment #8730343 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Updated•9 years ago
|
status-firefox45:
--- → wontfix
status-firefox46:
--- → affected
status-firefox47:
--- → affected
status-firefox48:
--- → affected
status-firefox-esr45:
--- → wontfix
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8730343 [details] [diff] [review]
Simplify and cleanup ServiceWorkerInfo. r=ehsan
Approval Request Comment
[Feature/regressing bug #]: Service workers.
[User impact if declined]: I'd like to uplift this to make other future uplifts easier. It also removes some code that could be theoretically lead to crashes.
[Describe test coverage new/current, TreeHerder]: Existing mochitests and wpt tests.
[Risks and why]: Minimal.
[String/UUID change made/needed]: None
Attachment #8730343 -
Flags: approval-mozilla-beta?
Attachment #8730343 -
Flags: approval-mozilla-aurora?
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment on attachment 8730343 [details] [diff] [review]
Simplify and cleanup ServiceWorkerInfo. r=ehsan
While code cleanup should ideally ride the trains, given that this will help simplify future bug fixes and we have good automated test coverage, I am ok to take it in Aurora47.
Attachment #8730343 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8730343 [details] [diff] [review]
Simplify and cleanup ServiceWorkerInfo. r=ehsan
We should also uplift to Beta46.
Attachment #8730343 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Comment 7•9 years ago
|
||
| bugherder uplift | ||
|
|
||
Comment 8•9 years ago
|
||
| bugherder uplift | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•