Closed Bug 1256506 Opened 9 years ago Closed 9 years ago

Move gaia to chrome:// urls

Categories

(Firefox OS Graveyard :: Runtime, defect)

Product:
Firefox OS Graveyard
Component:
Runtime
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: fabrice, Assigned: gerard-majax)

References

Details

(Whiteboard: fixed-in-pine)

Attachments

(2 files, 11 obsolete files)

Move gaia to chrome:// URLs
(deleted), patch
Details | Diff | Splinter Review
Remove app:// protocol
(deleted), patch
Details | Diff | Splinter Review
Attached patch chrome-gaia.patch (obsolete) (deleted) — — Splinter Review
This patch goes with the gaia branch at https://github.com/fabricedesre/gaia/tree/gaia-chrome You need to clean up /data/local and /data/b2g before running $gaia/push_apps.sh *this is not working yet*, and I'd like to get a new pair of eyes on that. If we crash in web components code, this is likely bug 1253788.
I'm building to investigate
So I am getting a segfault within Chrome_ChildThr and later system app fails loading with ReferenceError on LazyLoader: > 03-15 11:14:36.380 1749 1749 E GeckoConsole: [JavaScript Error: "ReferenceError: LazyLoader is not defined" {file: "chrome://gaia/content/system.gaiamobile.org/js/app.js" line: 54}] > 03-15 11:14:36.380 1749 1749 E GeckoConsole: App.prototype.start@chrome://gaia/content/system.gaiamobile.org/js/app.js:54:7 > 03-15 11:14:36.380 1749 1749 E GeckoConsole: startApp@chrome://gaia/content/system.gaiamobile.org/js/bootstrap.js:17:5 > 03-15 11:14:36.380 1749 1749 E GeckoConsole: @chrome://gaia/content/system.gaiamobile.org/js/bootstrap.js:23:5 > 03-15 11:14:36.380 1749 1749 E GeckoConsole: @chrome://gaia/content/system.gaiamobile.org/js/bootstrap.js:3:2
After several attempts, uptodate gecko up to 344f5598d6bc93c3e51f9dcee7a1047bb43f9c55 boots properly. I fear the crash I am experiencing might be related to pine specifically.
Attached file tombstone_00 (obsolete) (deleted) —
tombstone of the crash in Chrome_ChildThr
Attached file addr2line of tombstones (obsolete) (deleted) —
B2G_DEBUG=1: > 03-16 14:08:32.050 2506 2508 F MOZ_Assert: Assertion failure: sLogModuleManager != nullptr, at /home/alex/codaz/Mozilla/gecko-cinnabar/xpcom/base/Logging.cpp:261 > 03-16 14:08:32.050 2506 2508 F libc : Fatal signal 11 (SIGSEGV) at 0x00000000 (code=1), thread 2508 (Chrome_ChildThr)
(In reply to Alexandre LISSY :gerard-majax from comment #8) > B2G_DEBUG=1: > > 03-16 14:08:32.050 2506 2508 F MOZ_Assert: Assertion failure: sLogModuleManager != nullptr, at /home/alex/codaz/Mozilla/gecko-cinnabar/xpcom/base/Logging.cpp:261 > > 03-16 14:08:32.050 2506 2508 F libc : Fatal signal 11 (SIGSEGV) at 0x00000000 (code=1), thread 2508 (Chrome_ChildThr) Looks like Chromium IPC logging code does weird things. > 03-16 14:31:51.680 2731 2734 I Gecko : LogModule::Get(aName=chromium) sLogModuleManager == nullptr? 1 > 03-16 14:31:51.680 2731 2734 F MOZ_Assert: Assertion failure: sLogModuleManager != nullptr, at /home/alex/codaz/Mozilla/gecko-cinnabar/xpcom/base/Logging.cpp:262 > 03-16 14:31:52.000 2724 2724 I Gecko : LogModule::Init() sLogModuleManager == nullptr? 1 I have a workaround that seems to do the trick locally. And I hit new crashes: > 03-16 14:51:47.290 2930 2930 E GeckoConsole: [JavaScript Error: "TypeError: path is null" {file: "resource://gre/modules/osfile/ospath_unix.jsm" line: 60}] > 03-16 14:51:47.290 2930 2930 F MOZ_Assert: Assertion failure: !webPath.IsEmpty(), at /home/alex/codaz/Mozilla/gecko-cinnabar/netwerk/ipc/NeckoParent.cpp:85 And later: > 03-16 14:51:48.410 2936 2936 I Gecko : > 03-16 14:51:48.410 2936 2936 I Gecko : ###!!! [Child][MessageChannel::SendAndWait] Error: Channel error: cannot send/recv > 03-16 14:51:48.410 2936 2936 I Gecko : > 03-16 14:51:48.410 2936 2936 I Gecko : [Child 2936] WARNING: MsgDropped in ContentChild: file ../../../../../../../gecko-cinnabar/dom/ipc/ContentChild.cpp, line 2285 > 03-16 14:51:48.420 2936 2936 I Gecko : LogModule::Get(aName=JSComponentLoader) sLogModuleManager == nullptr? 0 > 03-16 14:51:48.420 2936 2936 I Gecko : LogModule::Get(aName=nsJarProtocol) sLogModuleManager == nullptr? 0 > 03-16 14:51:48.510 723 738 E Diag_Lib: [IMS_FATAL]| 2992 | 738 |ims-rtp-daemon ims_rtp_qmi_handler_thread_func waiting on select thread> > 03-16 14:51:48.720 2936 2936 I Gecko : [Child 2936] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /home/alex/codaz/Mozilla/gecko-cinnabar/toolkit/xre/nsXREDirProvider.cpp, line 1461 > 03-16 14:51:48.890 723 738 E Diag_Lib: [IMS_FATAL]| 2992 | 738 |ims-rtp-daemon ims_rtp_qmi_handler_thread_func waiting on select thread> > 03-16 14:51:48.920 2936 2936 I Gecko : > 03-16 14:51:48.920 2936 2936 I Gecko : ###!!! [Child][MessageChannel] Error: (msgtype=0x4E0001,name=PCrashReporter::Msg_AnnotateCrashReport) Channel error: cannot send/recv > 03-16 14:51:48.920 2936 2936 I Gecko : > 03-16 14:51:48.920 2936 2936 I Gecko : [Child 2936] WARNING: MsgDropped in ContentChild: file ../../../../../../../gecko-cinnabar/dom/ipc/ContentChild.cpp, line 2285 > 03-16 14:51:49.000 2936 2936 I Gecko : LogModule::Get(aName=InMemoryDataSource) sLogModuleManager == nullptr? 0 > 03-16 14:51:49.000 2936 2936 I Gecko : [Child 2936] WARNING: Unable to printf the requested string due to error.: file /home/alex/codaz/Mozilla/gecko-cinnabar/ipc/chromium/src/base/string_util.cc, line 427 > 03-16 14:51:49.000 2936 2936 I Gecko : > 03-16 14:51:49.000 2936 2936 I Gecko : ###!!! [Child][MessageChannel] Error: (msgtype=0xFFF9,name=???) Channel error: cannot send/recv > 03-16 14:51:49.000 2936 2936 I Gecko : > 03-16 14:51:49.000 2936 2936 I Gecko : [Child 2936] WARNING: MsgDropped in ContentChild: file ../../../../../../../gecko-cinnabar/dom/ipc/ContentChild.cpp, line 2285 > 03-16 14:51:49.000 2936 2936 I Gecko : [Child 2936] WARNING: FileDescriptorSet destroyed with unconsumed descriptors: file /home/alex/codaz/Mozilla/gecko-cinnabar/ipc/chromium/src/chrome/common/file_descriptor_set_posix.cc, line 20 > 03-16 14:51:49.000 2936 2936 I Gecko : [Child 2936] WARNING: FileDescriptorSet destroyed with unconsumed descriptors: file /home/alex/codaz/Mozilla/gecko-cinnabar/ipc/chromium/src/chrome/common/file_descriptor_set_posix.cc, line 20 > 03-16 14:51:49.000 2936 2936 F MOZ_CRASH: Hit MOZ_CRASH(Failed to create top level actor!) at /home/alex/codaz/Mozilla/gecko-cinnabar/ipc/glue/BackgroundImpl.cpp:2078
Ok, crash in comment 9 is probably because of https://hg.mozilla.org/projects/pine/file/tip/netwerk/ipc/NeckoParent.cpp#l85 and the TypeError explains it.
Attached patch Bug XXX - Workaround racy chromium logging (obsolete) (deleted) — — Splinter Review
MozReview-Commit-ID: KDtFIFgOtfd
MozReview-Commit-ID: 3DE9lv3z3FA
We also need to adb push shared /system/b2g/apps/shared/.
(In reply to [:fabrice] Fabrice Desré from comment #0) > Created attachment 8730467 [details] [diff] [review] > chrome-gaia.patch > > This patch goes with the gaia branch at > https://github.com/fabricedesre/gaia/tree/gaia-chrome > > You need to clean up /data/local and /data/b2g before running > $gaia/push_apps.sh > > *this is not working yet*, and I'd like to get a new pair of eyes on that. > If we crash in web components code, this is likely bug 1253788. I have been finally able to get this reproduced and I do confirm we crash when loading web components, more specifically at: > 0 PinPageSystemDialog/</<(undefined) ["chrome://gaia/content/system.gaiamobile.org/js/pin_page_system_dialog.js":33] https://github.com/fabricedesre/gaia/blob/gaia-chrome/apps/system/js/pin_page_system_dialog.js#L33
MozReview-Commit-ID: FjH0tfCPgRw
Comment on attachment 8731300 [details] [diff] [review] Bug XXX - Workaround MOZ_ASSERT against webPath.IsEmpty() This is coming from bug 815523: "Remote the app: and jar: protocols." For app: I think we can get rid of it without risks :). But for jar: I'm not so sure?
MozReview-Commit-ID: 3DE9lv3z3FA
Attachment #8731300 - Attachment is obsolete: true
Attached patch Use no gaiamobile.org domain (obsolete) (deleted) — — Splinter Review
MozReview-Commit-ID: 9yxZaVkuOxo
Comment on attachment 8731299 [details] [diff] [review] Bug XXX - Workaround racy chromium logging So that patch is only needed when playing with B2G_DEBUG=1. I dont reproduce the race condition leading to this crash with B2G_DEBUG=0
Attached patch Move gaia to chrome:// URLs (obsolete) (deleted) — — Splinter Review
Attachment #8730467 - Attachment is obsolete: true
Attachment #8731299 - Attachment is obsolete: true
Attachment #8731579 - Attachment is obsolete: true
Attachment #8731662 - Attachment is obsolete: true
Attachment #8731718 - Attachment is obsolete: true
Attached patch Remove app:// protocol (obsolete) (deleted) — — Splinter Review
Attachment #8731239 - Attachment is obsolete: true
Attachment #8731242 - Attachment is obsolete: true
Attachment #8731244 - Attachment is obsolete: true
Assignee: nobody → lissyx+mozillians
Attached patch Move gaia to chrome:// URLs (deleted) — — Splinter Review
MozReview-Commit-ID: HguO5sUeZx5
Attachment #8732129 - Attachment is obsolete: true
Attached patch Remove app:// protocol (deleted) — — Splinter Review
MozReview-Commit-ID: a8Do43h9Cj
Attachment #8732130 - Attachment is obsolete: true
Whiteboard: fixed-in-pine
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/117001541
Ben Francis changed story state to accepted in Pivotal Tracker
Status: RESOLVED → VERIFIED
Depends on: 1265613
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: