Closed Bug 1256648 Opened 8 years ago Closed 6 years ago

Google logo overlaps when scrolling

Categories

(Web Compatibility :: Desktop, defect)

Firefox 48
defect
Not set
normal

Tracking

(platform-rel +, firefox46 wontfix, firefox47 wontfix, firefox48 wontfix, firefox49 fix-optional)

RESOLVED INVALID
Tracking Status
platform-rel --- +
firefox46 --- wontfix
firefox47 --- wontfix
firefox48 --- wontfix
firefox49 --- fix-optional

People

(Reporter: sbadau, Assigned: karlcow)

References

()

Details

(Keywords: regression, Whiteboard: [gfx-noted] [apz-evangelism] [country-all] [sitewait] [css][platform-rel-Google])

Attachments

(2 files)

Attached video 2016-03-15 10h38_02.mp4 (deleted) —
Mozilla/5.0 (Windows NT 6.3; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160314030215

[Affected versions]:
Nightly 48.0a1
Aurora 47.0a2

[Affected platforms]:
Windows 8.1
Mac OS X 10.11

[Steps to reproduce]:
1. Navigate to Google news: https://news.google.com/
2. Scroll down and then up again to reach the Google logo 

[Expected result]:
Scrolling is smooth.

[Actual result]:
Google Logo hangs when scrolling (please see the attached video for more details).

[Regression range]:
Please let me know if a regression range is needed.

[Additional notes]:
- the issue doesn't seems to be as noticeable on Ubuntu or on Firefox Beta 46.0b1 and Firefox 45 RC.
Thanks for the report. Since this is scrolling-related there's a chance this could be an APZ problem. A regression range could come in useful, but before you spend time finding one it might be worth checking if you can reproduce this with layers.async-pan-zoom.enabled = false in about:config (requires a restart after toggling).

Also, it would be useful to attach the about:support for Nightly on an affected platform and also on Ubuntu. (Here I'm wondering whether e10s and therefore APZ is disabled on Ubuntu for some reason, hence why it doesn't affect it.)
Flags: needinfo?(simona.marcu)
Attached image Frame from video (deleted) —
The video is pretty low framerate so it's hard to tell what the problem is, but I stepped through it in QuickTime and saw one frame where the logo was "overlapping" the left sidebar. Simona, can you confirm that this is the problem you're referring to?
The problem happens not because of the logo, but because the sidebar is changed from position:fixed to position:absolute, and so is delayed in repositioning properly. If they were to use position:sticky instead then it wouldn't happen. It's relatively minor compared to some of the other websites we've seen with this problem. This is a result of APZ, one of the scroll-linked effects.
Blocks: apz-desktop
Whiteboard: [gfx-noted][apz-evangelism]
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #2)
> Created attachment 8731680 [details]
> Frame from video
> 
> The video is pretty low framerate so it's hard to tell what the problem is,
> but I stepped through it in QuickTime and saw one frame where the logo was
> "overlapping" the left sidebar. Simona, can you confirm that this is the
> problem you're referring to?

Yes, the "overlapping" is the problem I'm referring to.
Flags: needinfo?(simona.marcu)
Summary: Google logo hangs when scrolling → Google logo overlaps when scrolling
As per comment 3, the site should be using position:sticky. Moving to Tech Evangelism.
Component: Panning and Zooming → Desktop
Product: Core → Tech Evangelism
I get jank when I scroll in general on this site, but it's sort of intermittent -- only when I do sort of a fling up or down gesture with my mouse (if that makes any sense). Maybe every 4th fling.

Kats, can you reproduce the scroll jank?
Flags: needinfo?(bugmail.mozilla)
Looking at the page source, it is still doing the same thing as before (switching between position:fixed and position:absolute) but I'm not actually able to reproduce the overlap - I think the switch happens quickly enough that it's not really noticeable. However if the main thread is stuck/slow for whatever reason then it would probably still be noticeable.
Flags: needinfo?(bugmail.mozilla)
Can we confirm the status here?  Do we know it's evangelism issue, or could there be a bug on our side?  Or is it a fuzzy spec?
Flags: needinfo?(bugmail)
It's one of the fallout issues inherent in APZ. We would like them to use position:sticky instead of switching between position:fixed and position:absolute based on the scroll offset, hence evangelism.
Flags: needinfo?(bugmail)
Karl, can we ask Google to use position:sticky here? They're working on an implementation so it will be good for them at some point in the future as well.
Flags: needinfo?(kdubost)
Whiteboard: [gfx-noted][apz-evangelism] → [gfx-noted][apz-evangelism][country-all][needscontact]
I had hard time noticing it in the video too. 
And I can't reproduce on Nightly 51.0a1 (2016-08-17) on macosx. 
And I can't reproduce on Firefox 48.

I will contact Google, but I have the feeling that will not be part of their priorities.

Contacted today
Assignee: nobody → kdubost
Status: NEW → ASSIGNED
Flags: needinfo?(kdubost)
Whiteboard: [gfx-noted][apz-evangelism][country-all][needscontact] → [gfx-noted] [apz-evangelism] [country-all] [sitewait] [css]
We got a response with two axis:
1. Why should we do it?
2. We will look into it.

for the 1st one I gave reasons.

1. https://www.chromestatus.com/features/6190250464378880
  and https://bugs.chromium.org/p/chromium/issues/detail?id=231752#c49
  If  I understand it's ready to go more public.

2. working in Safari and Firefox
  http://caniuse.com/#feat=css-sticky

3. Under consideration for Edge
  https://developer.microsoft.com/en-us/microsoft-edge/platform/status/positionsticky

4. Google sends different codes to Firefox and Chrome already. (Though we want to avoid this as much as possible.)
platform-rel: --- → ?
Whiteboard: [gfx-noted] [apz-evangelism] [country-all] [sitewait] [css] → [gfx-noted] [apz-evangelism] [country-all] [sitewait] [css][platform-rel-Google]
Version: Trunk → Firefox 48
Google's answer

> "position: sticky" seems useful and I have raised this to our frontend folks.  
> It turned out, they already knew about this feature.  However, I don't know 
> of the ETA as it is a matter of their priorities when they get to test this 
> on Firefox on various platforms and also on other browsers.
Thanks Karl. Hopefully Google's implementation of pos:sticky will come sooner than later and it will be an easier sell.
platform-rel: ? → +
Rank: 80
> The great news is that as of Chrome 56 (currently beta 
> as of December 2016, stable in Jan 2017) position: sticky 
> is now back in Chrome.
https://developers.google.com/web/updates/2016/12/position-sticky
There's a new design, and it always uses a pos:fixed header, rather than attempting to emulate sticky. I think we can close now.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Product: Tech Evangelism → Web Compatibility
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: