Closed
Bug 1257019
Opened 9 years ago
Closed 9 years ago
Add move construction to js::Mutex<T>
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8730982 -
Flags: review?(terrence)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8730982 [details] [diff] [review]
Add move construction to js::Mutex<T>
Review of attachment 8730982 [details] [diff] [review]:
-----------------------------------------------------------------
Please add tests covering the new functionality to jsapi-tests/testThreadingMutex.cpp.
Attachment #8730982 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8731877 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8730982 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•9 years ago
|
||
Attachment #8731883 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8731877 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•9 years ago
|
||
Now with tests and rebase!
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f48510ffeb4a
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 8•9 years ago
|
||
No, that wasn't your try push, that was four meaningless jobs which stayed tier-1 while RyanVM accidentally made everything that matters tier-3 for a while. Your try push would be https://treeherder.mozilla.org/#/jobs?repo=try&revision=f48510ffeb4a&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=18237582
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b0e2c28119d8
|
|
Assignee | |
Comment 9•9 years ago
|
||
Ok, let's try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe91dc28bcb0
Attachment #8733132 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8731883 -
Attachment is obsolete: true
|
||
Comment 11•9 years ago
|
||
Keywords: checkin-needed
|
||
Comment 12•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•