Closed
Bug 1257055
Opened 9 years ago
Closed 9 years ago
Use jit/arm64/Architecture-arm64.h on non-JIT aarch64
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
lth
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1253216 +++
We should use Architecture-arm64.h if aarch64 platfrom without jit. (Now, jit is disabled on aarch64 platfrom)
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8731023 [details] [diff] [review]
Use jit/arm64/Architecture-arm64.h on non-JIT aarch64
Follow up Bug 1253216.
You know, aarch64 is turned off Ion JIT. We already has AtomicOperations-arm64.h, so even if non-JIT, we should use it.
And, including jit/arm64/Architecture-arm64.h on jit/arm64/AtomicOperations-arm64.h is unnecessary. And if including it without JS_CODEGE_ARM64, it causes build error due to conflict of jit/none/Architecture-none.h.
Attachment #8731023 -
Flags: review?(lhansen)
Comment 3•9 years ago
|
||
Comment on attachment 8731023 [details] [diff] [review]
Use jit/arm64/Architecture-arm64.h on non-JIT aarch64
Review of attachment 8731023 [details] [diff] [review]:
-----------------------------------------------------------------
OK, since the ARM64 JIT is stuck in traffic behind SIMD and Wasm.
I'm going to file a bug reminding myself to remove this code again once the ARM64 JIT is finished.
Attachment #8731023 -
Flags: review?(lhansen) → review+
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → m_kato
Comment 5•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•