Closed
Bug 1257173
Opened 9 years ago
Closed 9 years ago
JSON Viewer: fix eslint warnings
Categories
(DevTools :: JSON Viewer, defect, P2)
DevTools
JSON Viewer
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: Honza, Assigned: Honza)
References
Details
(Whiteboard: [btpp-fix-later])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
linclark
:
review+
|
Details | Diff | Splinter Review |
Make the devtools/jsonview directory clean
Honza
Assignee | ||
Comment 1•9 years ago
|
||
Lin, just making JSON viewer code clean (comments for react props will come soon)
Honza
Assignee | ||
Comment 2•9 years ago
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8731282 [details] [diff] [review]
bug1257173.patch
Review of attachment 8731282 [details] [diff] [review]:
-----------------------------------------------------------------
The patch looks fine, but it seems there are a lot of prop type errors in the try push.
Attachment #8731282 -
Flags: review?(lclark) → review-
Updated•9 years ago
|
Priority: -- → P2
Whiteboard: [btpp-fix-later]
Assignee | ||
Comment 4•9 years ago
|
||
Patch updated.
New try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1be5a490d05a
(btw. This bug is needed for bug 1256757 that is needed for bug 1247064, bug 1244912 and other JSON Viewer bugs)
NI me so, I don't forget to check the try results.
Honza
Attachment #8731282 -
Attachment is obsolete: true
Flags: needinfo?(odvarko)
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8731660 [details] [diff] [review]
bug1257173.patch
Lin, the try push looks good (not finished yet tho). I am assigning the review again to you, let's see if the prop types are alright now.
Honza
Flags: needinfo?(odvarko)
Attachment #8731660 -
Flags: review?(lclark)
Comment 6•9 years ago
|
||
Comment on attachment 8731660 [details] [diff] [review]
bug1257173.patch
Review of attachment 8731660 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM, thanks!
Attachment #8731660 -
Flags: review?(lclark) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 8•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•