Closed
Bug 1257178
Opened 9 years ago
Closed 9 years ago
this._input is undefined when running gcli tests
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)
DevTools Graveyard
Graphic Commandline and Toolbar
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
There is some exceptions happening in devtools/client/commandline/test/browser_cmd_commands.js and some other tests since I landed bug 1248601.
https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=220192149ce4
http://archive.mozilla.org/pub/firefox/tinderbox-builds/fx-team-linux64-debug/1458117646/fx-team_ubuntu64_vm-debug_test-mochitest-devtools-chrome-7-bm116-tests1-linux64-build26.txt.gz
04:27:11 INFO - JavaScript error: resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/developer-toolbar.js, line 508: TypeError: this._input is undefined
04:27:12 INFO - --DOCSHELL 0x7ff318f78800 == 10 [pid = 1947] [id = 22]
That's most likely before the toolbar is hidden early or hidden while it is in process of being show...
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8731247 -
Flags: review?(jwalker)
|
||
Updated•9 years ago
|
Attachment #8731247 -
Flags: review?(jwalker) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/c1f0341f9055edd241c8de6663aab14209a766b5
Bug 1257178 - Prevent "this._input is undefined" exception when developer toolbar is hidden early. r=jwalker
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•