Fennec no longer supports Old Sync accounts -- it only supports Firefox Accounts. However, we still have a "Using Old Sync?" link in our Synced Tabs panel state when we have no Firefox Account. This ticket tracks removing the link and associated code. The string is https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/remote_tabs_setup.xml#39. Remove the string from the layout; remove the string from strings.xml.in and sync_strings.dtd; and then remove the ID and click handlers. See https://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=old_sync%20path%3Amobile&redirect=true.

Comment on attachment 8732554 [details] [diff] [review] oldsync.patch Review of attachment 8732554 [details] [diff] [review]: ----------------------------------------------------------------- Patch is looking good. Please remove the string declaration and flag me for re-review. Thanks, Narek! ::: mobile/android/services/src/main/java/org/mozilla/gecko/fxa/FirefoxAccounts.java @@ -230,5 @@ > - public static String getOldSyncUpgradeURL(final Resources res, final Locale locale) { > - final String VERSION = AppConstants.MOZ_APP_VERSION; > - final String OS = AppConstants.OS_TARGET; > - final String LOCALE = Locales.getLanguageTag(locale); > - return res.getString(R.string.fxaccount_link_old_firefox, VERSION, OS, LOCALE); There is a string declaration too: https://dxr.mozilla.org/mozilla-central/source/mobile/android/services/strings.xml.in#25 (and the comment above it).

Comment on attachment 8732651 [details] [diff] [review] This one does not include the changes of the previous patch Review of attachment 8732651 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! I will fold these down into patch and land them. Great work! Narek, I don't have a lot of great Fennec mentor tickets right now. Would you be interested in Bug 1251053? It requires a little experimentation.

https://hg.mozilla.org/integration/fx-team/rev/2bcffdc79a71348899735978ac2747415572dfc1 Bug 1257901 - Remove references to Old Sync. r=nalexander