Closed
Bug 1258163
Opened 9 years ago
Closed 9 years ago
Implement Array.prototype[@@unscopables]
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
shu
:
review+
bholley
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•9 years ago
|
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8732574 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8732646 -
Flags: review?(shu)
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
|
Assignee | |
Comment 4•9 years ago
|
||
|
|
Assignee | |
Comment 5•9 years ago
|
||
Attachment #8732684 -
Flags: review?(shu)
Attachment #8732684 -
Flags: review?(bobbyholley)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8732646 -
Attachment is obsolete: true
Attachment #8732646 -
Flags: review?(shu)
|
|
Assignee | |
Comment 6•9 years ago
|
||
r?bobbyholley because I'm touching js/xpconnect/tests/chrome/test_xrayToJS.xul.
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8732684 [details] [diff] [review]
Implement Array.prototype[@@unscopables]
Review of attachment 8732684 [details] [diff] [review]:
-----------------------------------------------------------------
r=me on the Xray test.
Attachment #8732684 -
Flags: review?(bobbyholley) → review+
|
||
Comment 8•9 years ago
|
||
Comment on attachment 8732684 [details] [diff] [review]
Implement Array.prototype[@@unscopables]
Review of attachment 8732684 [details] [diff] [review]:
-----------------------------------------------------------------
1) Please add a js test as well showing that none of the names show up when you with(someArray).
2) Could you confirm that airbnb works with this patch?
::: js/src/jsarray.cpp
@@ +3287,5 @@
> }
>
> +static bool
> +array_proto_finish(JSContext* cx, JS::HandleObject ctor, JS::HandleObject proto)
> +{
Have a comment here referencing ES 22.1.3.32 please.
Attachment #8732684 -
Flags: review?(shu) → review+
|
|
Assignee | |
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7131e0ac868f61fc8db5ee972e6ee21dfc4766cd
Bug 1258163 - Implement Array.prototype[@@unscopables]. r=shu, r=bholley.
|
||
Comment 10•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
|
||
Comment 11•9 years ago
|
||
https://developer.mozilla.org/en-US/Firefox/Releases/48#JavaScript
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/@@unscopables
Keywords: dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•