Closed
Bug 1258479
Opened 9 years ago
Closed 9 years ago
Rename PCompositor
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
Details
Attachments
(2 files)
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
PCompositor is a confusing name since it has very little relation to Compositor. It's more related to the function ImageBridge serves, so Matt suggested renaming it to PCompositorBridge.
This would leave us with CompositorBridgeParent and CompositorBridgeChild.
Any objections?
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8733177 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8733178 -
Flags: review?(matt.woodrow)
Updated•9 years ago
|
Attachment #8733177 -
Flags: review?(matt.woodrow) → review+
Updated•9 years ago
|
Attachment #8733178 -
Flags: review?(matt.woodrow) → review+
Comment 4•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/92ece637da91
https://hg.mozilla.org/mozilla-central/rev/4f1482e6da91
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment 5•9 years ago
|
||
Could you update the Crash Signature field on the open bugs with a matching name please?
https://bugzilla.mozilla.org/buglist.cgi?f1=cf_crash_signature&o1=substring&resolution=---&chfieldto=Now&query_format=advanced&chfield=cf_crash_signature&v1=PCompositor
(keep the old signature, add a copy with the new naming scheme)
Flags: needinfo?(dvander)
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Mats Palmgren (:mats) from comment #5)
> Could you update the Crash Signature field on the open bugs with a matching
> name please?
> https://bugzilla.mozilla.org/buglist.
> cgi?f1=cf_crash_signature&o1=substring&resolution=---
> &chfieldto=Now&query_format=advanced&chfield=cf_crash_signature&v1=PComposito
> r
> (keep the old signature, add a copy with the new naming scheme)
Add a copy?
Flags: needinfo?(dvander)
Comment 7•9 years ago
|
||
Sorry, what I meant is something like this, for each bug:
* copy the text from the Crash Signature field into a text editor
* search+replace PCompositor -> PCompositorBridge (or what is appropriate)
* append that text to the existing signatures in the Crash Signature field
IOW, make sure the Crash Signature fields for the bugs above have both the old
signatures and the (expected) new signatures, so that both old and new crash
reports on https://crash-stats.mozilla.com/ will match and be linked to the bug.
Updated•9 years ago
|
Flags: needinfo?(dvander)
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(dvander)
You need to log in
before you can comment on or make changes to this bug.
Description
•