Closed
Bug 1258717
Opened 9 years ago
Closed 7 years ago
Split up browser_aboutHome.js mochitest into smaller tests and stop requesting longer timeout
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: mikedeboer, Assigned: Mardak, Mentored)
References
Details
The amount of tests has been gradually growing in https://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/general/browser_aboutHome.js and the running time has been growing longer with it.
At the time of this bug filing, `requestLongerTimeout()` has reached `4`. That's four times the allotted time for a mochitest-browser unit test.
Suggested division:
browser_aboutHome_snippets.js
browser_aboutHome_search.js
browser_aboutHome_buttons.js
...to start with. It's entirely possible that in practice we need to separate it further; most likely into search1.js and search2.js, because they can take quite a long time.
Flags: qe-verify-
Flags: firefox-backlog+
Comment 1•7 years ago
|
||
This is going to get fixed with the patch in bug 1396274, so I'm going to mark this as a wontfix.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•7 years ago
|
Resolution: WONTFIX → DUPLICATE
Assignee | ||
Comment 3•7 years ago
|
||
Ran into intermittents and leaks when splitting it up with bug 1396274, so not splitting up quite yet.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee | ||
Comment 4•7 years ago
|
||
Bug 1399648 ended up splitting browser_aboutHome.js into 9 test files where 5 files are aboutHome_search_* with one test each. Turns out a couple tests were still timing out even when run by itself with no requested longer timeout:
https://hg.mozilla.org/mozilla-central/rev/f36eefa1beee
+[browser_aboutHome_search_composing.js]
+skip-if = os == "linux" && !debug && bits == 32 # Bug 1399648
+[browser_aboutHome_search_suggestion.js]
+skip-if = os == "mac" || (os == "linux" && !debug) # Bug 1399648
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Depends on: 1399648
Resolution: --- → FIXED
Assignee | ||
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•