Closed
Bug 125881
Opened 23 years ago
Closed 23 years ago
nsIProperties.Has() misbehaves for empty values
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla0.9.9
People
(Reporter: BenB, Assigned: BenB)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
dougt
:
review+
jband_mozilla
:
superreview+
|
Details | Diff | Splinter Review |
If you have a property with 0 as value (because you don't need it, just the
existance of the property), Has returns false. This is broken.
From old code:
// XXX this is bogus because it doesn't distinguish between properties
// defined with a value NULL, and undefined properties, but we'll fix
// it later if it becomes a problem
Would've been nice, if you told me in the interface :). (I was hunting that bug
in my own code.)
Will attach patch. Please review.
|
Assignee | |
Comment 1•23 years ago
|
||
|
|
Assignee | |
Updated•23 years ago
|
|
||
Comment 2•23 years ago
|
||
Comment on attachment 69846 [details] [diff] [review]
Proposed fix, version 1
r=dougt
Attachment #69846 -
Flags: review+
|
||
Comment 3•23 years ago
|
||
Comment on attachment 69846 [details] [diff] [review]
Proposed fix, version 1
sr=jband
Attachment #69846 -
Flags: superreview+
|
|
Assignee | |
Comment 4•23 years ago
|
||
checked in. Thanks for the fast reviews! :-)
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Comment 5•23 years ago
|
||
to reopen cf bug 138138.
|
|
||
Comment 6•23 years ago
|
||
I mean 'caused regression' not 'to reopen'. Can stay fixed as the other bug was
created.
NB:
> "Thanks for the fast reviews! :-)"
Too fast? ;)
|
|
Assignee | |
Comment 7•23 years ago
|
||
I don't think so, see the other bug.
You need to log in
before you can comment on or make changes to this bug.
Description
•