Closed
Bug 1259024
Opened 9 years ago
Closed 9 years ago
developer-toolbar-closebutton has wrong tooltiptext
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)
DevTools Graveyard
Graphic Commandline and Toolbar
Tracking
(firefox45 unaffected, firefox46 unaffected, firefox47 wontfix, firefox48 verified, firefox-esr45 unaffected)
VERIFIED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox45 | --- | unaffected |
firefox46 | --- | unaffected |
firefox47 | --- | wontfix |
firefox48 | --- | verified |
firefox-esr45 | --- | unaffected |
People
(Reporter: magicp.jp, Assigned: ochameau)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160322030417
Steps to reproduce:
1. Start Nightly (or Aurora)
2. Open the Developer Toolbar (Shift + F2)
3. Confirm tooltiptext of developer-toolbar-closebutton
Actual results:
tooltiptext is "developerToolbarCloseButton.tooltiptext"
Expected results:
tooltiptext is "Close Developer Toolbar"
Regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4295f9951e9331a2f2bd0a8ea8c4ad73af141a7b&tochange=9da51cb4974e03cdd8fa45a34086fe1033abfeaf
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox45:
--- → unaffected
status-firefox46:
--- → unaffected
status-firefox47:
--- → affected
status-firefox48:
--- → affected
status-firefox-esr45:
--- → unaffected
Component: Untriaged → Developer Tools: Graphic Commandline and Toolbar
OS: Unspecified → All
Hardware: Unspecified → All
Comment 2•9 years ago
|
||
bug 1216478 did not cause this. Please always continue with mozregression to get an fx-team/inbound regression range. Don't assume that changesets with the right word in their summary are necessarily at fault.
Looking at the code here, this was caused by bug 1248601.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → poirot.alex
Flags: needinfo?(poirot.alex)
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
I'm moving these dtd to properties as dtd only works in static documents.
(i.e. don't work on dynamically inserted XUL elements)
But note that the close icon is completely gone in my local build.
I can't say if it is related to some other patch in my queue or bug 1257348.
(reverting bug 1257348 made it visible again, except on hover)
Attachment #8735811 -
Flags: review?(jwalker)
Assignee | ||
Updated•9 years ago
|
Attachment #8735799 -
Attachment is obsolete: true
Updated•9 years ago
|
Attachment #8735811 -
Flags: review?(jwalker) → review+
Comment 5•9 years ago
|
||
(In reply to Alexandre Poirot [:ochameau] from comment #4)
> But note that the close icon is completely gone in my local build.
> I can't say if it is related to some other patch in my queue or bug 1257348.
>
> (reverting bug 1257348 made it visible again, except on hover)
Is there a separate bug on file about this issue?
Flags: needinfo?(poirot.alex)
Assignee | ||
Comment 6•9 years ago
|
||
Not that I know of. Are you able to reproduce?
I'm very surprised bug 1257348 would regress exactly what it was attempting to fix?!!
Did you verified bug 1257348? Does close button works fine for you?
Would it be linux specific?
Flags: needinfo?(poirot.alex) → needinfo?(bgrinstead)
Comment 7•9 years ago
|
||
(In reply to Alexandre Poirot [:ochameau] from comment #6)
> Not that I know of. Are you able to reproduce?
I didn't try. I took your word for it! :-)
It sounded like you were seeing a separate problem to this bug, namely that the close icon wasn't showing up except when hovered - is that right? If so, especially if you can reproduce on today's nightly (you might have to force download it, updates are off atm) then you can file it and we can investigate more there? :-)
Assignee | ||
Comment 8•9 years ago
|
||
Ok, I'm able to reproduce on Linux from a 03/30 build.
Not on windows, from a 03/29 build (I imagine bug 1257348 is already in this build)
So it seems to be OS specific.
Flags: needinfo?(bgrinstead)
Assignee | ||
Comment 9•9 years ago
|
||
Opened bug 1260751.
Assignee | ||
Comment 10•9 years ago
|
||
Assignee | ||
Comment 11•9 years ago
|
||
Assignee | ||
Comment 12•9 years ago
|
||
Ready to land once fxteam reopens.
Assignee | ||
Comment 13•9 years ago
|
||
Assignee | ||
Comment 14•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/21be9fc9356d9ee4f396a5263b0aa1b47266eb8a
Bug 1259024 - Fix developer toolbox close and toolbar toggle button tooltips. r=jwalker
Comment 15•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Reporter | ||
Comment 17•8 years ago
|
||
Verified in 48.
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•