Closed
Bug 1259182
Opened 9 years ago
Closed 9 years ago
Shrink keyCodeData
Categories
(Core :: XBL, defect)
Core
XBL
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
We can shrink keyCodeData for a tiny win.
|
Assignee | |
Comment 1•9 years ago
|
||
uint8_t would actually be enough for both of the changed fields, but due to the
|char*| uint16_t results in the same value for sizeof(keyCodeData).
Attachment #8734038 -
Flags: review?(bzbarsky)
|
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8734038 [details] [diff] [review]
Shrink keyCodeData
r=me, though some static_asserts about the relevant sizeof and keycode values fitting in 16 bits would be good.
Attachment #8734038 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
> r=me, though some static_asserts about the relevant sizeof and keycode
> values fitting in 16 bits would be good.
I checked -- GCC errors if either of the fields is ever assigned a value that's too large.
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/050be20c329ffee6a43faeb721c46c15016db341
Bug 1259182 - Shrink keyCodeData. r=bz.
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•