Closed Bug 1260399 Opened 8 years ago Closed 6 years ago

Revert bug 1259169

Categories

(Core :: DOM: Core & HTML, defect, P3)

47 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: baku, Assigned: baku)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: btpp-active)

Attachments

(5 files)

      No description provided.
Depends on: 1259169
Component: Networking: Cookies → DOM
We branch on Monday.
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Whiteboard: btpp-active
I don't think we are going to do it... We will break too many addons doing it.
We should wait a bit more.
Flags: needinfo?(amarchesini)
Summary: Revert bug 1259169 in FF47-FF48 → Revert bug 1259169
Keywords: good-first-bug
Assignee: amarchesini → nobody
Priority: -- → P3
Assignee: nobody → amarchesini
Attachment #9010920 - Flags: review?(ehsan)
Attached patch part 1 - nsICookieManager.add() (deleted) — Splinter Review
Attachment #9010921 - Flags: review?(ehsan)
Attachment #9010922 - Flags: review?(ehsan)
Here I changed the logic: instead of passing a cookie and considering just its host/path/name, I prefer to have a method with 3 separate fields.
Attachment #9010923 - Flags: review?(ehsan)
Attachment #9010924 - Flags: review?(ehsan)
Attachment #9010920 - Flags: review?(ehsan) → review+
Attachment #9010921 - Flags: review?(ehsan) → review+
Attachment #9010922 - Flags: review?(ehsan) → review+
Attachment #9010923 - Flags: review?(ehsan) → review+
Attachment #9010924 - Flags: review?(ehsan) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75c91b472821
Remove deprecated messages in nsICookieManager methods - part 0 - nsICookieManager.remove() should not have optional parameters, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea67de243b02
Remove deprecated messages in nsICookieManager methods - part 1 - nsICookieManager.add(), r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/35fb4a8d10f7
Remove deprecated messages in nsICookieManager methods - part 2 - nsICookieManager.getCookiesFromHost(), r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/761834f331a7
Remove deprecated messages in nsICookieManager methods - part 3 - nsICookieManager.cookieExists, r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c1fb6fac9c4
Remove deprecated messages in nsICookieManager methods - part 4 - remove the deprecated message, r=ehsan
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: