Closed
Bug 126040
Opened 23 years ago
Closed 16 years ago
javascript strict warnings in nsProgressDlg.js
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: bugzilla, Assigned: jag+mozilla)
References
Details
(Whiteboard: [See comment 6])
Attachments
(1 obsolete file)
Warning: reference to undefined property dialog.strings[stringId]
Source File: chrome://global/content/nsProgressDlg.js
Line: 236
to reproduce:
0) enable strict js warns
1) go to http://dilbert.gemal.dk/
2) right click and save image
20020213
|
||
Comment 2•23 years ago
|
||
This code is obsolescent. I'll entertain similar complaints about the new code,
nsProgressDialog.js, tomorrow.
Target Milestone: --- → Future
|
|
||
Comment 4•23 years ago
|
||
marking wfm. i'm not seeing this with a cvs build from today on win2k.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME
|
Reporter | |
Comment 5•23 years ago
|
||
the warn could still show since the code is still there. The download dialog
just doesn't seem to use it anymore. The code should be fixed or the
function/file should be removed.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
|
||
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
|
||
Comment 6•17 years ago
|
||
Comment on attachment 70082 [details] [diff] [review]
patch
There is no <.../nsProgressDlg.js> (anymore):
From
<http://mxr.mozilla.org/mozilla/search?string=Check+if+we%27ve+fetched+this+s&case=on&find=%5C.js%24&filter=%5E%5B%5E%5C0%5D*%24&tree=mozilla>
only
<http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/xpfe/components/download-manager/src/nsDownloadProgressListener.js&rev=1.19&mark=264#261>
has this issue.
This patch needs to be unbitrotted.
Attachment #70082 -
Attachment is obsolete: true
|
|
||
Updated•17 years ago
|
Assignee: law → jag
Status: REOPENED → NEW
QA Contact: bugzilla
Whiteboard: [See comment 6]
Target Milestone: Future → ---
|
||
Comment 7•16 years ago
|
||
WONTFIX. We will be moving to the toolkit download manager "Real Soon Now"
Status: NEW → RESOLVED
Closed: 23 years ago → 16 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•