Closed Bug 1260406 Opened 9 years ago Closed 4 years ago

DLC Sync: Hook into /changes call platform does

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: sebastian, Unassigned)

References

Details

There's a /changes API that lists all collections and the last time they have been updated. For example here: https://kinto-ota.dev.mozaws.net/v1/buckets/monitor/collections/changes/records The sync client on JS side already polls this API to only run sync code for blocklists etc. if there has been changes. With that we can reduce the number of individual collection polls. On Fennec side we are running the DLC client in Java. It would be nice to trigger our client whenever the platform sync client has seen changes for our collection.
@Mark: Can you point me to some code about how to add a client for a specific collection? I'll then add code to ping my java client. I found this here but there are no clients yet and I would need to add one for mobile only: https://dxr.mozilla.org/mozilla-central/source/services/common/kinto-updater.js
Flags: needinfo?(mgoodwin)
Currently, you simply create an object with a maybeSync function (e.g. see https://dxr.mozilla.org/mozilla-central/source/services/common/KintoCertificateBlocklist.js#49) and add it to the kinto clients in kintup-updater.js (see https://dxr.mozilla.org/mozilla-central/source/services/common/kinto-updater.js#78) There's a slight change being made in bug 1257556 - there's a slight change made to the way clients are added (see the changes to services/common/kinto-updater.js). You can either create your own file as before, or perhaps add an item to KintoBlocklist.js I'm not sure how best to handle the fact that we won't want the same list of clients in fennec - maybe Mathieu has thoughts on this.
Flags: needinfo?(mgoodwin)
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.