Closed
Bug 1260577
Opened 9 years ago
Closed 9 years ago
obj[foo] += 5 calls ToPropertyKey on foo twice, against spec.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: efaust, Assigned: efaust)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
This is the lamest thing ever. Just because everyone else does it, doesn't mean we have to, also.
Clean up an open-coding of emitElemOperands along the way :).
Attachment #8736059 -
Flags: review?(jorendorff)
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → efaustbmo
Status: NEW → ASSIGNED
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8736059 [details] [diff] [review]
Fix
Review of attachment 8736059 [details] [diff] [review]:
-----------------------------------------------------------------
Stealing so we can land this straight away.
Attachment #8736059 -
Flags: review?(jorendorff) → review+
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8736059 [details] [diff] [review]
Fix
Review of attachment 8736059 [details] [diff] [review]:
-----------------------------------------------------------------
"SelfAssign" is unobvious to me. Does that mean compound assignment? (The ES spec doesn't seem to have a name for += and friends; "compound" is the word the Java Language Spec uses.)
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cd2868983231
https://hg.mozilla.org/mozilla-central/rev/57e8e4c71ecf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•